Fix upload pipeline for collection-instance (rigged) models; add validator dry-run - #2065
Draft
Tweekazoid wants to merge 6 commits into
Draft
Tweekazoid wants to merge 6 commits into
Tweekazoid wants to merge 6 commits into
Conversation
Tweekazoid
marked this pull request as draft
April 30, 2026 21:36
Contributor
|
This is a big deal if we finally fix it, we should have a call maybe. |
Tweekazoid
marked this pull request as ready for review
May 5, 2026 08:17
Tweekazoid
marked this pull request as draft
May 21, 2026 21:57
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
…lity_upload # Conflicts: # autothumb.py # upload_bg.py Co-authored-by: Tweekazoid <7928647+Tweekazoid@users.noreply.github.com>
Co-authored-by: Tweekazoid <7928647+Tweekazoid@users.noreply.github.com>
Co-authored-by: Tweekazoid <7928647+Tweekazoid@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2065 +/- ##
==========================================
- Coverage 34.21% 34.03% -0.18%
==========================================
Files 87 88 +1
Lines 27581 27800 +219
==========================================
+ Hits 9436 9461 +25
- Misses 18145 18339 +194
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix upload pipeline for collection-instance (rigged) models; add validator dry-run
Problem
Models using collection-instance empties (e.g. rigged trams with body segments as instanced collections) were uploaded broken: geometry was missing, duplicated, or invisible because the pipeline only tracked direct parent/child hierarchies and didn't account for Blender's three-tier visibility system.
Changes
utils.pyget_hierarchy_with_instances()walksinstance_collectionreferences in addition toobject.children, with cycle detection. Used byupload.pyandautothumb.py.upload.pyget_hierarchy_with_instancesto buildinstance_collection_namesandobjects_in_instance_cols; excludes the latter fromobnamesto prevent double-loading._snapshot_and_project_visibility/_restore_visibilityhelpers that project per-view-layer eye-hide state ontoObject.hide_viewport/Collection.hide_viewportbeforesave_as_mainfile(copy=True), then restore — so eye-hidden objects stay hidden after append into a fresh scene.upload_bg.pyinstance_collectionpointers instead of a second explicitlibraries.load(which caused.001duplicates).bpy.dataso instance empties can still reference them for rendering.upload_dryrun.py(new)prepare_asset_datalogic, invokesupload_bg.pyin a non-blocking subprocess thread, optionally opens the resulting blend in a new Blender instance.ui_panels.pyprofile_is_validator()), model/printable assets only.