Fix scroll arrow direction for multi-row asset bar - #1956
PetrDlouhy wants to merge 8 commits into
Conversation
|
@vilemduha Co ty na tohle? Jen jednoduché otočení těch šipek, když máme víc řádkový asset bar. |
|
@Tweekazoid Ještě jsem malinko zjednodušil ten kód. Obecně se mi úplně nelíbí, že potřebujeme 3 šipky nad sebou, ale to je úplně jiná věc. |
|
stale ty sipky nevypadaji konzistentne bohuzel, Muselo by dojit k refactoru BL_UI_Button a BL_UI_Image chtelo by to: takze kdyz button bude tak se auto-scaluje na 100*33 vcera nebo predvcirem jsem tam pridal pro obrazky padding kvuli borderu, kdy ten BL widget (jak button tak image) a proste bude se menit pouze velikost widgetu, a uz se nebude muset menit velikost obrazku, to bude automaticke 
|
|
@Tweekazoid Zkusím s tím něco udělat, ale nevím, jestli je to úplně ve scope tohohle jednoduchého PR. Oni ani ty staré šipky nejsou moc konzistentní: 
|
|
Podle mě by bylo úplně nejlepší tam mít použít stejnou ikonu (to bude UTF-8 symbol) jako je pro to roztažení panelu dolů. A použít jen jednu, ne 3x. |
|
mozna tohle >> vlastne asi ne, protoze ten nas label nepodporuje dobre multiline |
|
testni jestli to bude vypaddat dobre, a muzeme to nechat jen na UTF symbolech jestli to nebude pusobit moc nevyvazene |
- Switch to up/down arrow icons when asset bar has multiple rows - Scale scroll_width with UI resolution instead of hardcoding 30px - Fix scroll button width not updating reliably on layout refresh (set width before set_location so batch_panel rebuilds correctly) - Add properly padded arrow_up.png and arrow_down.png (35x116) that don't clip when rendered at aspect-preserving sizes - Extract update_scroll_button_icons() to handle icon selection and aspect-ratio-preserving image sizing in one place Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
0b2beb2 to
3e4aa7d
Compare
|
@Tweekazoid There was problem even with the image. Now I think this is working nicely and the scaling works for the new icons as well as for the old ones. We talked with @vilemduha that we will not merge this into this new release, but leave it to further discussion. We would probably need to talk about this with more users. |
|
@copilot resolve the merge conflicts in this pull request |
…ction # Conflicts: # asset_bar/asset_bar_op.py # test.py # tests/test_asset_bar_op.py Co-authored-by: Tweekazoid <7928647+Tweekazoid@users.noreply.github.com>
Co-authored-by: Tweekazoid <7928647+Tweekazoid@users.noreply.github.com>
Conflicts are resolved and |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1956 +/- ##
==========================================
+ Coverage 34.21% 34.31% +0.10%
==========================================
Files 87 87
Lines 27581 27627 +46
==========================================
+ Hits 9436 9480 +44
- Misses 18145 18147 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Co-authored-by: Tweekazoid <7928647+Tweekazoid@users.noreply.github.com>
Co-authored-by: Tweekazoid <7928647+Tweekazoid@users.noreply.github.com>
Co-authored-by: Tweekazoid <7928647+Tweekazoid@users.noreply.github.com>
Co-authored-by: Tweekazoid <7928647+Tweekazoid@users.noreply.github.com>
Co-authored-by: Tweekazoid <7928647+Tweekazoid@users.noreply.github.com>
Single-row asset bar scrolls horizontally (left/right arrows), but multi-row scrolls vertically while still showing left/right arrows. Switch to up/down arrow icons when hcount > 1, with proportional sizing to preserve aspect ratio of the source images.
Made-with: Cursor