Refine Code City Apocalypse Dashboard Logic#29
Conversation
- Update is_event_success to handle historical dataset CSV columns. - Correct Model Success Rates leaderboard to filter by unique successes. - Ensure all active models are displayed in the leaderboard. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the event success logic to include a check for the flag_found_last_attempt_flag, refactors dictionary iteration in get_monster_info, and modifies render_apocalypse_metrics to ensure all active models are represented in the leaderboard even with zero successes. A review comment suggested dropping null values when identifying unique active models to prevent 'NaN' entries from appearing in the final metrics output.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: BleakNarratives <bleaknarratives@gmail.com>
1 participant
This PR refines the success detection and leaderboard logic in the AIRTBench dashboard. It ensures that the historical dataset CSV is correctly interpreted by checking for the
flag_found_last_attempt_flagcolumn. Additionally, the 'Model Success Rates' leaderboard has been corrected to only count unique successful challenges per model and to include all active models, even those with zero successes.PR created automatically by Jules for task 4784603244228825561 started by @BleakNarratives