fix: correct model success rate calculation and detection#27
fix: correct model success rate calculation and detection#27BleakNarratives wants to merge 2 commits into
Conversation
- Update `is_event_success` to detect successes from archive CSV `flag_found_last_attempt_flag` column. - Refactor `render_apocalypse_metrics` to correctly calculate "Sectors Cleared" by filtering for successful events. - Ensure all models are represented in the leaderboard, including those with zero successes. - Minor ruff lint fix for ERROR_MAP iteration. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Code Review
This pull request updates the event success criteria, simplifies dictionary key iteration, and refines the apocalypse metrics leaderboard to include models with zero successes. Feedback was provided to improve the leaderboard data processing by handling potential null model names and ensuring consistent integer types for sector counts.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: BleakNarratives <bleaknarratives@gmail.com>
This PR fixes a bug in the "Code City Apocalypse" dashboard where the "Sectors Cleared" metric (and the "Model Success Rates" chart) incorrectly counted all unique challenge attempts as successes.
Key changes:
is_event_successhelper to recognize successful flag submissions in the archive dataset by checking theflag_found_last_attempt_flagcolumn.render_apocalypse_metricsto filter the failure data for successful rows before aggregating unique challenges per model.Verified via Playwright screenshots and passed
ruffandmypychecks.PR created automatically by Jules for task 1364947910522008593 started by @BleakNarratives