Code City Apocalypse Frontend Revamp#20
Conversation
This commit implements several enhancements to the AIRTBench-Code dashboard: - Revamps the 'Emergency Broadcast' ticker with support for success events (HOPE) and failure events (CRITICAL) with distinct color coding. - Refactors the 'Digital Bestiary' using custom CSS lore cards and severity-weighted progress bars. - Implements dynamic calculation of 'Active Agents' from live telemetry data. - Unifies artifact rendering logic in the 'Fallout Inspector' and improves chat message parsing. - Enhances data robustness by normalizing difficulty levels and error key lookups. - Updates caching strategy for live data feeds to ensure near real-time updates. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enhances the frontend by expanding difficulty levels, improving the emergency ticker with success event handling and color coding, and introducing a styled 'Digital Bestiary'. It also refactors file inspection logic and adds dynamic metrics for active agents. Review feedback highlights a potential crash when escaping NaN values in the ticker, suggests using dictionary mapping instead of nested ternaries for better readability, and recommends escaping dynamic content in HTML blocks to mitigate XSS risks.
| severity_val = ( | ||
| 0.9 | ||
| if info["danger"] == "ULTIMATE" | ||
| else 0.6 | ||
| else 0.75 | ||
| if info["danger"] == "CRITICAL" | ||
| else 0.4, | ||
| else 0.5 | ||
| if info["danger"] == "HIGH" | ||
| else 0.25 | ||
| ) |
There was a problem hiding this comment.
The nested ternary operator for calculating severity_val is becoming difficult to read and maintain as more danger levels are added. Using a dictionary mapping would be much cleaner and more idiomatic.
severity_val = {"ULTIMATE": 0.9, "CRITICAL": 0.75, "HIGH": 0.5}.get(info["danger"], 0.25)
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: BleakNarratives <bleaknarratives@gmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: BleakNarratives <bleaknarratives@gmail.com>
BleakNarratives
left a comment
BleakNarratives
left a comment
There was a problem hiding this comment.
Good enough for the fat ladies I fux with...
1 participant
I have completed the frontend overhaul for the "Code City Apocalypse" dashboard. Key improvements include:
.lore-card) and a progress bar that scales by severity.error_typeanderrorkeys).Verification was performed using logic tests and Playwright automation to ensure visual fidelity across all dashboard tabs.
PR created automatically by Jules for task 412334072720472153 started by @BleakNarratives