Skip to content

ci: update Node 20 to Node 22 LTS - #155

Merged
sachushaji merged 1 commit into
masterfrom
fix/node-20-eol-ci
Sep 7, 2026
Merged

ci: update Node 20 to Node 22 LTS#155
sachushaji merged 1 commit into
masterfrom
fix/node-20-eol-ci

Conversation

@ralph-bitgo

@ralph-bitgo ralph-bitgo Bot commented Sep 7, 2026

Copy link
Copy Markdown

Summary

Node 20 reached end of life in April 2026, so CI was running unit tests and lint on an unsupported runtime. This updates both CI jobs (unit-test, lint) in .github/workflows/ci.yml to Node 22 LTS, and bumps actions/setup-node from v3 to v4 (v3 runs on GitHub's deprecated node16 runner runtime).

Closes SCAAS-11269.

Decision log

  1. Which Node version — Options: (a) Node 22 LTS, (b) Node 24 LTS (active LTS since Oct 2025), (c) do nothing. Chose (a) Node 22: it is still under LTS support (maintenance until ~April 2027), satisfies the ticket, and is the conservative bump — engines (>=20.19.0) and all dependencies are known-compatible. Node 24 is available if the team prefers the newest LTS; trivial follow-up.
  2. Bump actions/setup-node v3 → v4 — v3 runs on the deprecated node16 runner runtime and GitHub warns against it; v4 is the current major. Included since it is the same workflow line and carries no behavior change beyond the runtime.
  3. Did not touch package.json engines or CLAUDE.mdengines: >=20.19.0 remains valid for Node 22, and changing the local dev baseline is developer-facing scope beyond this ticket.

Test evidence

Verified locally on Node v22.23.2 (via nix):

  • npm ci — clean install.
  • npm test207 passing (6s).
  • npm run linteslint . and hardhat check both clean.

CI on this PR will exercise the updated workflow itself.

Open questions

None.

@ralph-bitgo

ralph-bitgo Bot commented Sep 7, 2026

Copy link
Copy Markdown
Author

@claude please review

@ralph-bitgo
ralph-bitgo Bot force-pushed the fix/node-20-eol-ci branch from 0ba5771 to 07cbaa0 Compare September 7, 2026 13:18
@linear-code

linear-code Bot commented Sep 7, 2026

Copy link
Copy Markdown

SCAAS-11269

Node 20 reached end of life in April 2026, so CI jobs ran on an
unsupported runtime. Bump both CI jobs (unit-test, lint) to Node 22
LTS and actions/setup-node v3 to v4 (v3 runs on the deprecated
node16 runner runtime).

Ticket: SCAAS-11269
Signed-off-by: sachuabraham@bitgo.com <sachuabraham@bitgo.com>
Session-Id: 0edd029f-e0a7-4339-b636-b8c7a863bcbe
Task-Id: 315b5f51-d93a-44b2-afd5-a074a5702cb7
@ralph-bitgo
ralph-bitgo Bot force-pushed the fix/node-20-eol-ci branch 2 times, most recently from 3f7e428 to 5a07568 Compare September 7, 2026 13:20
@sachushaji
sachushaji marked this pull request as ready for review September 7, 2026 13:42
@sachushaji
sachushaji requested a review from a team as a code owner September 7, 2026 13:42
@sachushaji
sachushaji enabled auto-merge September 7, 2026 13:42

@vipulchaursiya908 vipulchaursiya908 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@sachushaji
sachushaji merged commit fc30a89 into master Sep 7, 2026
7 checks passed
@sachushaji
sachushaji deleted the fix/node-20-eol-ci branch September 7, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants