Skip to content

fix(wasm-mps): migrate legacy EdDSA MPCv2 keyshares - #388

Open
Marzooqa wants to merge 1 commit into
masterfrom
marzooqakather498/wci-1496-add-old-struct-decode-fallback-migration-for-eddsa-mpcv2
Open

fix(wasm-mps): migrate legacy EdDSA MPCv2 keyshares#388
Marzooqa wants to merge 1 commit into
masterfrom
marzooqakather498/wci-1496-add-old-struct-decode-fallback-migration-for-eddsa-mpcv2

Conversation

@Marzooqa

@Marzooqa Marzooqa commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Ticket: WCI-1496

@linear-code

linear-code Bot commented Sep 9, 2026

Copy link
Copy Markdown

WCI-1496

@Marzooqa
Marzooqa force-pushed the marzooqakather498/wci-1496-add-old-struct-decode-fallback-migration-for-eddsa-mpcv2 branch 2 times, most recently from 32e0974 to 635a545 Compare September 9, 2026 13:50
@Marzooqa
Marzooqa force-pushed the marzooqakather498/wci-1496-add-old-struct-decode-fallback-migration-for-eddsa-mpcv2 branch from 635a545 to 351842e Compare September 9, 2026 14:35
@Marzooqa
Marzooqa marked this pull request as ready for review September 9, 2026 14:47
@Marzooqa
Marzooqa requested a review from a team as a code owner September 9, 2026 14:47

@vibhavgo vibhavgo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does ed25519_hard_derive_round0_process also need to use decode_keyshare for root_share around line 855?

Since root_share is a persisted EdDSA keyshare, won't wallets DKG'd between June 30 and mid-July still fail deserialization during hardened child derivation (e.g., generating new receive addresses or signing with derived addresses), even though their root-key DSG signing is now fixed?

Could we update line 855 to use decode_keyshare::<EdwardsPoint>(root_share)? and add a test case covering hard derivation with a migrated legacy share?

@Marzooqa

Copy link
Copy Markdown
Contributor Author

Does ed25519_hard_derive_round0_process also need to use decode_keyshare for root_share around line 855?

Since root_share is a persisted EdDSA keyshare, won't wallets DKG'd between June 30 and mid-July still fail deserialization during hardened child derivation (e.g., generating new receive addresses or signing with derived addresses), even though their root-key DSG signing is now fixed?

Could we update line 855 to use decode_keyshare::<EdwardsPoint>(root_share)? and add a test case covering hard derivation with a migrated legacy share?

We dont need to do this for hard derivation as thats a feature thats gonna be used for wallet safes and for net new wallets.

@Marzooqa
Marzooqa requested a review from vibhavgo September 11, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants