feat(statics): onboard missing BTC.fiat currencies#8558
Closed
feng-bitgo wants to merge 2 commits intomasterfrom
Closed
feat(statics): onboard missing BTC.fiat currencies#8558feng-bitgo wants to merge 2 commits intomasterfrom
feng-bitgo wants to merge 2 commits intomasterfrom
Conversation
TICKET: SC-6398 Adds 14 fiat currencies (main + testnet) to allCoinsAndTokens.ts and their corresponding UnderlyingAsset enum values in base.ts: KRW, CAD, ZAR, AUD, CNY, TRY, ARS, CLP, COP, UYU, NOK, SEK, DKK, JPY Required for Lumina Market Data and the Asset Pricing Service to ingest FX rates for these currencies. KRW is especially time-sensitive for BitGo Korea users. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
TICKET: SC-6398 Add BaseCoin implementations for 14 new fiat currencies (main + testnet), register them in coinFactory, and export from sdk-core and bitgo modules: KRW, CAD, ZAR, AUD, CNY, TRY, ARS, CLP, COP, UYU, NOK, SEK, DKK, JPY Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
dupe, closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Onboards 14 fiat currencies into
@bitgo/staticsso that Lumina Market Data and the new Asset Pricing Service can ingest FX rates for them. KRW is time-sensitive for BitGo Korea users.Currencies added (main + testnet each):
fiatkrw— South Korean Wonfiatcad— Canadian Dollarfiatzar— South African Randfiataud— Australian Dollarfiatcny— Chinese Yuanfiattry— Turkish Lirafiatars— Argentine Pesofiatclp— Chilean Pesofiatcop— Colombian Pesofiatuyu— Uruguayan Pesofiatnok— Norwegian Kronefiatsek— Swedish Kronafiatdkk— Danish Kronefiatjpy— Japanese YenChanges
modules/statics/src/base.ts: Added 14 new entries toUnderlyingAssetenum (fiats section)modules/statics/src/allCoinsAndTokens.ts: Added 28fiat()entries (main + testnet for each currency)modules/statics/test/unit/fixtures/expectedColdFeatures.ts: Added all new coins to theneitherfixtureTest plan
yarn run unit-test --scope @bitgo/staticspasses ✅TICKET: SC-6398
🤖 Generated with Claude Code