feat(hbar): add staking support via AccountUpdateBuilder#8554
feat(hbar): add staking support via AccountUpdateBuilder#8554aditya-bitgo wants to merge 2 commits intomasterfrom
Conversation
|
@claude review this PR |
aditya-bitgo
force-pushed
the
SI-361
branch
2 times, most recently
from
940eda8 to
898a3a6
Compare
Doddanna17
left a comment
Doddanna17
left a comment
There was a problem hiding this comment.
Missing unit tests. Every builder in this SDK has a test file under test/unit/transactionBuilder/ — tokenAssociateBuilder.ts, transferBuilder.ts, etc. No accountUpdateBuilder.ts was added. The CI unit-test passes because existing tests weren't broken. At minimum need: happy path stake/unstake, validateMandatoryFields throwing when stakedNodeId is missing, signImplementation max-signer check, and initBuilder round-trip from a serialized tx.
Doddanna17
left a comment
Doddanna17
left a comment
There was a problem hiding this comment.
Added unit tests for AccountUpdateBuilder in modules/sdk-coin-hbar/test/unit/transactionBuilder/accountUpdateBuilder.ts covering stake, unstake, decline reward, round-trip serialization, and error paths (missing stakedNodeId, invalid account ID, max signers exceeded, invalid key). All 12 tests pass.
2 participants
ticket: SI-361