Repository navigation
fix(abstract-eth): verify ERC-7984 wrap/unwrap/finalizeUnwrap on multisig (CHALO-1957) - #10067
Merged
Venkat-Annavazzala merged 1 commit intoOct 26, 2026
Conversation
…isig (CHALO-1957) Onchain multisig verifyTransaction only exempted wrapApprove from the txParams.recipients requirement, so wrap, unwrap and finalizeUnwrap legs could never pass verification and ended in 'missing params'. Add an explicit multisig path for the three intent types. It is content-based on the sendMultiSig args in txHex: wrapper target resolved from a registry scoped to the wallet's network, self-directed base address rules, and well-formed calldata fields. The user key signs the operation hash over txPrebuild.recipients[0], not over txHex, so the prebuild must carry exactly one recipient whose address, amount and data equal the decoded sendMultiSig args. The same strict check now also applies to the existing wrapApprove path. Ticket: CHALO-1957
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 1 of CHALO-1957, split from #10063 so the ETH-ecosystem change can be reviewed on its own.
Onchain-multisig
verifyTransactiononly exemptedwrapApprovefrom itstxParams.recipientsrequirement.wrap,unwrapandfinalizeUnwraplegs therefore always ended inmissing params. They are built server-side from the intent or the journey, so no client recipients exist for them.Changes
txHex:unwrap— strict: target is the registered wrapper forunwrapParams.tokenName, args self-directed to the wallet base, non-empty ciphertext and proofwrap— strict whenwrapParamsis present, bounded otherwise (registered wrapper target, mint recipient is the wallet base, positive amount)finalizeUnwrap— bounded: registered wrapper target and well-formed request fieldsEth.signTransactionbuilds the operation hash fromtxPrebuild.recipients[0], not fromtxHex. The prebuild must now carry exactly one recipient whose address, amount and data equal the decoded sendMultiSig args. This also applies to the existingwrapApprovepath, which previously skippeddataandamount.Tests
Unit tests in
sdk-coin-eth/test/unit/eth.tscover every accept and reject branch, the network scoping, and the strict recipient check.Behaviour change to note
The existing
wrapApprovemultisig path now rejects a prebuild with no recipient, several recipients, missingdata, or a non-zero amount. Real prebuilds already carry the matching recipient.Follow-up
Part 2 is the
sdk-corechange that strips stored recipients on the PA-approve rebuild for these intent types (#10063, to be rebased on this PR once it merges).Ticket: CHALO-1957