Skip to content

feat(sdk-coin-canton): support Broadridge standing delegation intent - #10064

Merged
ravibitgo merged 1 commit into
masterfrom
CHALO-1960
Oct 26, 2026
Merged

ravibitgo merged 1 commit into
masterfrom
CHALO-1960

Conversation

@ravibitgo

Copy link
Copy Markdown
Contributor

Summary

Add end-to-end SDK support for the Canton
cantonBroadridgeStandingDelegation intent.

The intent accepts only executorPartyId; client-provided meta is not
accepted or forwarded.

Changes

  • Add executorPartyId to Canton/TSS intent and transaction parameter types.
  • Route cantonBroadridgeStandingDelegation through the TSS prebuild flow.
  • Validate:
    • the intent is only supported for Canton;
    • executorPartyId is required.
  • Mark the intent as a no-recipient transaction.
  • Preserve executorPartyId during pending-approval and re-sign flows.
  • Populate Canton intents with executorPartyId.
  • Verify prepared transactions as:
    • Canton CreateCommand;
    • CIP-56 StandingDelegationImpl_v1;
    • client-role standing delegation;
    • executor matching the requested executorPartyId.
  • Keep generic CantonCommandBuilder and existing Broadridge allocation/
    settlement authorization flows unchanged.

Tests

Added coverage for:

  • intent population;
  • missing executor validation;
  • non-Canton rejection;
  • no-recipient signing;
  • persisted executor propagation;
  • successful standing delegation verification;
  • executor mismatch rejection.

Verification

  • Focused sdk-core intent tests pass.
  • Focused Canton standing delegation tests pass.
  • Canton TypeScript compilation passes.
  • Prettier checks pass.

Ticket: CHALO-1960

@linear-code

linear-code Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

CHALO-1960

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

@ravibitgo
ravibitgo marked this pull request as ready for review October 26, 2026 11:12
@ravibitgo
ravibitgo requested review from a team as code owners October 26, 2026 11:12

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@ravibitgo
ravibitgo merged commit 702b1a8 into master Oct 26, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants