Repository navigation
fix: bump toml to 5.0.1 to fix osv-scanner findings - #10044
Merged
Merged
Conversation
toml@4.3.0 (root resolutions force-pin; only consumer is bitgo > stellar-sdk@10.4.1, which calls toml.parse() on /.well-known/stellar.toml responses) is in the affected range of advisories fixed in toml 5.0.1, most notably GHSA-4qx8-w7c3-pj3p (CVE-2026-114141, quadratic-complexity DoS in toml.parse() via many array-of-tables headers; CVSS 4.0 HIGH, fails the release HIGH/CRITICAL osv-scanner gate), plus GHSA-9j65-hcg3-gc64 (quadratic DoS via long dotted keys) and GHSA-9qmh-m7c6-f92p (super-linear CPU via oversized integer literals). v5.0.0 breaking change vs 4.3.0: integer values outside the safe (+/-2^53-1) or 64-bit range now throw at parse time instead of silently rounding; opt-in lossless handling via toml.parse(input, { bigint: true }). stellar-sdk's StellarTomlResolver only parses stellar.toml documents (string/URL values); verified by the sdk-coin-xlm federation unit tests. osv-scanner diff vs the master lockfile shows exactly the three flagged toml advisories removed and no new findings introduced. Ticket: INFOSEC-730
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
The INFOSEC- ticket prefix (used by the security team for dependency upgrade tickets, e.g. INFOSEC-730) was missing from the commitlint parser issuePrefixes, so commit footers referencing INFOSEC tickets failed the references-empty rule in CI (PR #10044 commit-lint job). Mirrors the earlier WEB- prefix addition in ef0927d. Ticket: INFOSEC-730
zahin-mohammad
approved these changes
Oct 23, 2026
pranishnepal
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the
tomlroot resolutions force-pin from 4.3.0 to 5.0.1 (INFOSEC-730).tomlhas no direct importers in this repo — its only consumer isbitgo>stellar-sdk@10.4.1, whoseStellarTomlResolvercallstoml.parse()on/.well-known/stellar.tomlresponses (exercised by thesdk-coin-xlmfederation tests).Why 5.0.1 and not 5.0.0
toml@4.3.0sits in the affected range of advisories fixed in 5.0.1:VA:H) — blocks the release osv-scanner gatetoml.parse()via many array-of-tables headers5.0.0 is still inside the
last_affected <= 5.0.0range, so the pin must be 5.0.1.v4 → v5 breaking change
Integers outside the safe (
±2^53-1) or 64-bit range now throw at parse time instead of silently rounding (opt-in lossless handling viatoml.parse(input, { bigint: true })).stellar.tomldocuments are conventionally string/URL values, so this is not reachable in stellar-sdk's usage; verified by smoke test and the federation unit tests.Verification
osv-scanner(v2.7.0, release config) on the new lockfile: toml findings: none; diff vs the master lockfile shows exactly the three toml advisories above removed and zero new findings introducedyarn check-deps: passessdk-coin-xlm108 passing,sdk-coin-algo231 passing,sdk-coin-hbar233 passing,bitgofull suite exit 0Ticket: INFOSEC-730