Repository navigation
feat: migrate recover to ExternalEd25519Signer - #10042
Merged
Merged
Conversation
Contributor
Migrate XLM and HBAR recover() from the pre-made externalBackupSignature hook to the shared lazy ExternalEd25519Signer, signing tx.hash() (XLM) and built bodyBytes (HBAR) via signWithExternalEd25519Signer. backupKey is now optional when an external signer is supplied. Also harden the shared helper to hand the callback a copy of the message so signed bytes cannot be mutated after the fact. Ticket: WCN-3754
pranishnepal
force-pushed
the
WCN-3754
branch
from
October 23, 2026 16:26
9dc2810 to
6d13114
Compare
Contributor
|
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
|
@claude review |
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
davidkaplanbitgo
approved these changes
Oct 23, 2026
MohammedRyaan786
approved these changes
Oct 23, 2026
danielpeng1
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate XLM and HBAR recover() from the pre-made externalBackupSignature hook to the shared lazy ExternalEd25519Signer, signing tx.hash() (XLM) and built bodyBytes (HBAR) via signWithExternalEd25519Signer. backupKey is now optional when an external signer is supplied. Also harden the shared helper to hand the callback a copy of the message so signed bytes cannot be mutated after the fact.
Follow-up from: #10012
Ticket: WCN-3754