Skip to content

Support footnotes and reference-style links - #119

Open
BinaryOutlook wants to merge 1 commit into
mainfrom
feat/footnotes-reference-links
Open

BinaryOutlook wants to merge 1 commit into
mainfrom
feat/footnotes-reference-links

Conversation

@BinaryOutlook

Copy link
Copy Markdown
Owner

Documents using shared link definitions and footnotes now render and remain editable in Visual, Source, and Split views. Adds full, collapsed, and shortcut references, footnote insertion and keyboard navigation, source preservation, linked HTML/PDF notes, and native DOCX/EPUB notes.

Tightens the editor guide, export help, changelog, and acceptance report while retaining syntax examples and format limits. Refs #113.

Validation:

  • 475 unit tests passed; 20 optional checks skipped. Compilation and lint passed with 11 existing warnings.
  • Final affected browser run: 149 passed. The full run had 1,275 passes and one stale command-count assertion, corrected and covered by the final run; the full suite was not repeated afterward.
  • Real Pandoc conversion and HTML/PDF/DOCX/EPUB inspection passed within the documented scope.
  • Source and rendered documentation reviews, link checks, and whitespace checks passed.

Installed-VS-Code save/reopen and interactive Word editing remain unverified, so this PR does not close #113.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T04:43:58.478002Z 6d3a71f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6d3a71f30f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +409 to 410
if (group.isMath || group.isReference)
return applyInlineStyles(group.text, group.styles);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve enclosing links when serializing reference atoms

When an ordinary inline link begins with a newly introduced reference atom, this early return discards the enclosing link's destination. For example, opening [\[label](https://example.com) tail, appending ! to that paragraph, and serializing produces \[label tail!, permanently removing the link. Likewise, [![a][image]](/outer) loses /outer after a neighboring edit. collectCharStyles marks these atoms as both isReference and isLink, but this branch bypasses link serialization; preserve the enclosing link when emitting the reference source. Untouched saves retain the original source and therefore conceal the problem until the paragraph changes.

AGENTS.md reference: AGENTS.md:L51-L51

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support footnotes and reference-style links across editing and export

1 participant