Repository navigation
Reuse deterministic fixture strings in scrub equivalence test - #1451
Merged
Merged
Conversation
Contributor
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 50 minutes. View limit details
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
BigSimmo
enabled auto-merge
November 5, 2026 04:44
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The independent old-algorithm oracle rebuilds the same deterministic zero-offset scenario fixture-string set on every session step. This prepares that immutable set once per test file while retaining the old event replay, linear matcher, key-leak rejection, scrubbing and restore validation.
The complete mixed session and assertion block are unchanged: every step is compared byte-for-byte, both loaded modes run, and non-null-copy, event-read-cost and refusal assertions remain. No production code, test timeout, coverage setting, test population or exception list changes.
Two earlier hosted attempts of the original document-rollout revision timed out in this test at 30 seconds. That original PR #1444 subsequently passed on its third attempt and merged as 3099a5f; this prevention repair is a separate follow-up and is not credited for that merge.
Validation:
The local interrupted-run lease was separately recovered under independent review and the existing coordinator gate, preserving its exact before-image and execution evidence. No force flag, fabricated completion state, adjacent record change or process stop was used in recovery. This PR contains only the test-file change.