Repository navigation
fix(sign-off): reset the #3562/#3571 sign-offs, restore the owner's lithium attestation, fix 18 therapy format labels - #3702
Conversation
…rapies with a contradictory format label
Owner ruling 21 Oct 2026 ("Go ahead with all recommendations"): the 27 therapy
sign-offs recorded as "Psych Sift" in #3562 were not the owner's, so they go back
to needs_review the same way as the 17 Oct reset (unticked checklist, earlier
completeness score, no reviewer, date or content pin; no attestation recorded).
Audit finding R7-F-13: 18 signed records showed the chip "Group programme" while
their own text says the therapy is usually individual. The chip is now
"Multi-session", matching the fix #3692 made to the unsigned records, and those
18 records return to needs_review for the owner to re-sign.
Therapy indexes, hashed assets (previous generation revoked) and the signable
projection are regenerated.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y5kedaqPZhZ1q8QUZeE2DQ
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5kedaqPZhZ1q8QUZeE2DQ
…the owner's 2 Oct lithium attestation
Owner ruling 21 Oct 2026 ("Go ahead with all recommendations"): the "Psych Sift"
sign-offs recorded in #3562 and #3571 were not the owner's.
- specifiers: 85 still-signed reviews back to clinician-review-pending with no
reviewer, date or pin (pending count 585); search index regenerated
- MHA s357 back to drafted (s14 was already reset by #3692); review sheet
regenerated offline
- source acquisitions: the two Australian Prescriber lithium records and the WA
clozapine guideline go back to their #3143 candidate state, which carries the
attestation the owner confirmed on 2 Oct
- ps-diff-src-au-ausprescr-lithium-2020 restored to its #3143 state, reversing the
18 Oct withdrawal (PS-009); check:source-acquisitions passes again
- services: the 21 #3143 sign-offs re-dated by #3571 return to their original date
(content pins unchanged)
- interaction lexicon: the 16 Oct re-sign is removed; the sheet now reports the
2026-09-28 sign-off as not current
- site-content static manifest baseline regenerated
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y5kedaqPZhZ1q8QUZeE2DQ
sign-offs; record the owner ruling Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5kedaqPZhZ1q8QUZeE2DQ
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5kedaqPZhZ1q8QUZeE2DQ
… therapy assets Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5kedaqPZhZ1q8QUZeE2DQ
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly identifies the primary changes: resetting the specified sign-offs, restoring the owner's lithium attestation, and correcting 18 therapy format labels. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 9… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Description check | |
The pull request description follows the required template. It includes a detailed summary, areas touched and RAG impact, verification results, risk and rollback information, provider effects, and not… |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 9 files. (13 skipped: 13 unsupported.)
Full details: Description check
-
Explanation
The pull request description follows the required template. It includes a detailed summary, areas touched and RAG impact, verification results, risk and rollback information, provider effects, and notes. It also documents the incomplete local verification and the required clinical governance checks.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
…gn-off Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5kedaqPZhZ1q8QUZeE2DQ
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5kedaqPZhZ1q8QUZeE2DQ
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔇 Additional comments: 8
src/data/source-acquisitions.json: 1
522-522: LGTM!Also applies to: 529-530, 533-535, 1292-1293, 1296-1298, 3146-3146, 3153-3154, 3157-3159, 3857-3857, 3860-3860, 3863-3864, 3873-3876
tests/medication-source-links.test.ts: 1
112-116: LGTM!tests/source-catalogue-providers.test.ts: 1
223-225: LGTM!src/data/therapies-index.json: 1
550-550: 🗄️ Data Integrity & IntegrationThe source-to-index comparison found zero tag mismatches in both projections.
"Group programme"is not a stale index value, so regeneration is not required for this record.data/repo-awareness-snapshot.json: 2
4-4: LGTM!
5741-5745: LGTM!tests/clinical-signoff-kinds.test.ts: 1
429-429: 🎯 Functional CorrectnessThe fixture intentionally uses
"PsychSift"as an invalid product stamp. The test asserts that these records remain drafted and that only"Psych Sift"produces a valid clinician review. No reviewer-name change is needed.docs/decisions/2026-10-21-psych-sift-sign-offs-in-3562-and-3571-reset.md-30-30: 1
30-30: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
⚠️ Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.Fix the issue reference so markdownlint passes.
Line 30 starts with
#3562, so markdownlint reports MD018. This is an issue reference, not a heading. Escape the hash or wrap the reference in code formatting.Proposed fix
-#3562 and still stands. +`#3562` and still stands.Source: Linters/SAST tools
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: BigSimmo/PsychSift/.coderabbit.yaml
- Review profile: CHILL
- Plan: Team
- Run ID:
636cfaff-9baf-416a-bccd-05994c0d9cba
📒 Files selected for processing: 27
data/mha-2014-sections.jsondata/repo-awareness-snapshot.jsondata/service-records-review.jsondata/specifiers-content.jsondata/specifiers-search-index.jsondocs/decisions/2026-10-21-psych-sift-sign-offs-in-3562-and-3571-reset.mddocs/evidence/mha-2014-section-summaries-review.mddocs/medication-interaction-lexicon-review.mdpublic/therapy-compass-data/therapies-index.536fb33cd2af2643.jsonpublic/therapy-compass-data/therapies.184677d4e81f8273.jsonpublic/therapy-compass-data/therapies.5f2d28d5d88a81d5.jsonpublic/therapy-compass-data/therapies.6c39eed4b6587d27.jsonsrc/data/source-acquisitions.jsonsrc/data/therapies-index.jsonsrc/data/therapies-source.jsonsrc/data/therapy-catalogue-assets.tssrc/data/therapy-signable-slugs.jsonsrc/lib/site-content/site-content-change-owners.jsontests/clinical-signoff-kinds.test.tstests/developer-sign-off-page.dom.test.tsxtests/fixtures/site-content/static-manifest-baseline.jsontests/medication-source-links.test.tstests/owner-sign-off-today.dom.test.tsxtests/sign-off-queue.test.tstests/sign-off-today.test.tstests/source-catalogue-providers.test.tstests/therapy-3510-needs-review.test.ts
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.
|
Auto-fix isn't included in your plan ↗ |
|
For the Claude session that owns this PR: the owner wants every PR unblocked (14:34 AWST 21 Oct, relayed by Grok Bot). What's blocking this PR right now? Please reply here with the blocker and anything you need from the owner or other agents (approvals, quota, a canary, a review). Helper 3 won't push to or arm this branch and will pass your answer on. |
|
OWNER HOLD (14:42 AWST 21 Oct, relayed by Grok Bot): please do NOT merge or arm #3702 until (1) the failing tests (therapy-key-facts 'Group programme'→'Multi-session', favourites-signed-out-sample 'reviewed'→'needs_review') are updated deliberately, with the user-visible change explained, and (2) the owner confirms the restored lithium attestation is exactly their original. Auto-merge must stay off. — Helper 3 |
CBT-I format chip is now Multi-session (R7-F-13); CBT-I is back to needs_review, so the signed-out favourites sample uses a still-reviewed therapy (CPT) to keep the 'only reviewed therapies' guarantee.
Code Review ✅ Approved🔴 High risk · Resetting sign-offs across 45 therapies and 585 specifiers and removing medicine source links could broadly change clinical reference material available on the live site. Resets the #3562 and #3571 sign-offs to awaiting the owner's review, restores the owner's 2 Oct lithium attestation, and corrects 18 therapy format labels from "Group programme" to "Multi-session". No new sign-offs or attestations are recorded. No issues found. VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Approved For more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
|
Requested by Josh · project thread
Summary
Before: the "Psych Sift" sign-offs recorded in #3562 and #3571 counted as the owner's. The owner's 2 Oct lithium source attestation was withdrawn on 18 Oct, so
check:source-acquisitionsfailed on main. Eighteen signed therapies showed the format chip "Group programme" while their own text says the therapy is usually individual.After: those sign-offs are back to awaiting the owner's review, the lithium attestation is restored exactly as the owner confirmed it through #3143, and the 18 therapies read "Multi-session" and wait for re-signing. No new sign-off or attestation is recorded.
This acts on the owner's answer to the three audit questions (R6-F-04, R6-F-01, R7-F-13), 21 Oct 2026 11:41 AWST: "Go ahead with all recommendations". Decision record:
docs/decisions/2026-10-21-psych-sift-sign-offs-in-3562-and-3571-reset.md.clinician-review-pendingwith no reviewer, date or pin, so all 603 wait (search index regenerated).needs_review(unticked checklist, earlier completeness score, no reviewer, date or pin). Indexes and hashed assets regenerated with--revoke-previous; signable projection and change-owner manifest updated.drafted(s14 was already reset by Correct clinical content errors found by the 20 Oct content audit #3692); review sheet regenerated offline.candidatestate.ps-diff-src-au-ausprescr-lithium-2020returns to its feat(clinical): reconcile owner-confirmed sign-offs and review state #3143 state with the owner's attestation, reversing PS-009 (ace6626).Areas touched: Clinical reference content, App experience, Knowledge and records, Prototypes, Answer engine, Data platform and access
RAG impact: no retrieval behaviour change. No protected retrieval file changed; under the 18 Oct ruling, reset therapy and specifier prose is withheld from answer evidence and site content until re-signed.
Verification
Test Files 73 passed (73),Tests 2243 passed (2243).check:source-acquisitions: "Source acquisition ledger passed." (failed on main before this change)check:therapy-data-index: "Therapy indexes are current (205 records)."check:mha-act-sections: "107 reviewed, 3 drafted, 0 pending"check:specifiers-search-index: current (585 items).--check: baseline digest matches, 0 added/removed/changed.format:changed,check:diff-integrity,sitemap:check,check:repo-awareness-snapshot,docs:check-index,docs:check-inventory,docs:check-links,check:decisions,check:outstanding-issuespass.verify:pr-localstops atcheck:installed-lock-parityin this container (install stamp mismatch, not a repo fault), so the rest of its list was run one by one.Risk and rollout
Clinical Governance Preflight
PsychSift Production(sjrfecxgysukkwxsowpy)Notes
npm run therapy:reviewandnpm run clinical:review.Generated by Claude Code
Summary by cubic
Resets the "Psych Sift" sign-offs recorded in #3562 and #3571 back to awaiting the owner's review, restores the owner's 2 Oct lithium source attestation, and fixes 18 therapy format labels. No new sign-off or attestation is recorded; a merge of main brings no behavioral change. The owner confirmed the Today page MHA timer sign-off, re-recorded in their own name in #3562, stands.
clinician-review-pending; all 585 written specifier definitions now wait.needs_review; those 18 chips now read "Multi-session".drafted; the two Australian Prescriber lithium records and the WA clozapine guideline return to their feat(clinical): reconcile owner-confirmed sign-offs and review state #3143candidatestate with the owner's attestation.needs_review.Visible effects
Written for commit 3737aba. Summary will update on new commits.
Summary by CodeRabbit
Content Review
Sign-off Changes
Documentation
Test changes (Helper 2, commit 3737aba)
tests/therapy-key-facts.test.ts— CBT-I format face assertion changed from "Group programme" to "Multi-session": this PR deliberately replaces the contradictory chip on the 18 signed therapies (R7-F-13), CBT-I among them.tests/favourites-signed-out-sample.dom.test.tsx— no assertion changed. The "only reviewed therapies" guarantee is kept; because CBT-I returns toneeds_reviewin this PR, the signed-out favourites sample (src/components/clinical-dashboard/favourites-sample-data.ts) now uses Cognitive Processing Therapy (CPT), which is stillreviewed. No clinical text changed.