Repository navigation
chore(gitar): merge commits only; never arm auto-merge on owner-seal holds - #3648
Conversation
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 8 minutes. View limit details
Comment |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0241e59c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Auto-fix isn't included in your plan ↗ |
Code Review ✅ Approved 1 closed / 1 findings🔴 High risk · The new Gitar criteria govern auto-merge authorization for migration PRs; misreading an owner-seal hold could arm an unapproved database change. Adds ✅ 1 closed✅ Quality: Owner-owned auto-merge rule omits 'do not disable' half
VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Approved For more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 3 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
Summary
.gitar/config/merge.md, the per-repository auto-merge criteria Gitar reads from the default branch (added to, never replacing, the organisation criteria).supabase/migrations/**) may still be armed once required checks pass, per the standing rule, but only when no owner-seal hold note is present..gitar/**in the Delivery and assurance area (docs/organisation/systems/delivery.json) so the organisation check stays clean..gitar/indocs/codebase-index.md(both root maps) so the codebase-index coverage check passes.Areas touched: Delivery and assurance, Knowledge and records
Verification
npm run check:organisation→ "organisation: exit 0 (pass) … 0 not yet placed, 0 unplaced";npm run check:instructions→ "instruction-budget: pass";npm run check:rule-consistency→ "rule-consistency: pass — 22 active source(s), 0 problem(s)";npm run docs:check-links→ "docs link check passed: 5972 repo path references resolve."node scripts/check-codebase-index-coverage.mjs→ "coverage OK: all 111 repository roots/modules/routes … are indexed";npm run check:repo-awareness-snapshot→ "in step";npm run docs:check-scriptsandnpm run check:decisionspass.Risk and rollout
Notes
main, so it takes effect only after merge.