Repository navigation
fix(sign-off): reset the agent-recorded Therapy Compass and DID sign-offs to needs_review - #3623
Conversation
…offs to needs_review Owner ruling 17 Oct 2026 22:12 AWST. #3613 stamped 26 Therapy Compass records and the reworded DID possession-form specifier as signed by "Psych Sift" at an identical round time (2026-10-17T12:15:00.000Z) without the interactive therapy:review / clinical:review tools. Neither tool has a revoke mode, so this resets status in the data (owner-approved) without recording any attestation: - therapies-source.json: 26 records back to needs_review, checklist unticked, pre-sign-off reviewCompleteness, reviewer/date/content pin removed - specifiers-content.json: DID item back to clinician-review-pending, reviewer, date and pin removed - regenerate therapy indexes/assets, the specifier search index, the signable therapy projection, the site-content manifest baseline and change owners - tests pin the restored counts (26 therapy waiting, 515 specifiers) - decision record; mark the #3613 sign-off decision superseded - ledger: cancel the pending done for #NZ4X41 and queue an update instead
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 48 minutes. View limit details
📝 Walkthrough
Merge Risk: 🟡 Moderate · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 11 files. (11 skipped: … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Title check The title clearly identifies the main change: resetting agent-recorded Therapy Compass and DID sign-offs to needs_review. Description check The description clearly explains the reset rationale, affected records, generated data, behavior changes, ledger updates, and verification performed. It does not reproduce the template's explicit Risk… Full details: Description check
-
Explanation
The description clearly explains the reset rationale, affected records, generated data, behavior changes, ledger updates, and verification performed. It does not reproduce the template's explicit Risk and rollout or Notes sections, and it does not provide decisive command output, but it is substantially complete and directly related to the pull request.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 11 files. (11 skipped: 11 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
✨ Finishing Touches: 💡 2
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
codeant-ai
Bot
added
the
size:XL
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
PR Summary by QodoReset invalid Therapy Compass and DID sign-offs to pending review
AI Description
Diagram
High-Level Assessment
Files changed (20)
|
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
Code Review by Qodo
No findings for this group No findings for this group No findings for this group Resolved findings 1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Qodo Fixer✅ Committed (3) · ☑ Fixed (3) Commits pushed directly to this PR — no separate fix PR opened. Process — 3 fixed
|
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
CodeAnt Nitpicks1 code suggestion1. With an empty question, therapy search returns alphabetical browse results, so this test never detects needs-review records being boosted for real clinical queries.Possible bug · |
CodeAnt PR Risk: Medium Risk
Assessed commit: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Code review by qodo was updated up to the latest commit ef9bfa6 |
|
Code review by qodo was updated up to the latest commit e4634d9 |
codeant-ai
Bot
added
size:XXL
qodo-code-review
Bot
added
🔴 Large blast radius
and removed
🟠 Medium blast radius
labels
|
Code review by qodo was updated up to the latest commit 16832fa |
…ire the pre-reset catalogue, keep sign-off projections current Owner ruling 18 Oct 2026 00:10 AWST (keep the gating and the 515 count). - site-content: a needs_review therapy is indexed by name and category only, so its unsigned prose cannot reach answer evidence through the site-content index; static-manifest baseline regenerated (26 therapy records) - build-therapies-index: --revoke-previous retires the retained previous generation; regenerated with it so pre-deploy clients fall back to the current alias instead of the pre-reset catalogue with revoked sign-offs - therapy:review writes therapy-signable-slugs.json inside its rollback-protected transaction, so a newly signed therapy leaves the owner to-do list - clinical:review clears changedSinceReview when it records a specifier signature - docs/decisions entry for the ruling; code comments point at it - tests for each
|
Code review by qodo was updated up to the latest commit dfb28b2 |
|
Auto-fix isn't included in your plan ↗ |
… change-owner manifest Root cause of the 'Change scope' failure: 4737972 retired the previous therapy catalogue generation (--revoke-previous), but site-content-change-owners.json still named those two hashed files, and ci-change-scope.mjs requires every listed owner path to exist (validateSiteContentChangeOwners). The owner list keeps the current generation and the public/therapy-compass-data/** glob.
Root cause of the Static PR checks failure on ab19fdd: the 2026-10-18 decisions entry made the committed snapshot's documentation list stale (regenerated with npm run snapshot:repo-awareness).
Code Review ✅ Approved 3 closed / 3 findings🔴 High risk · Resetting 26 therapy and one DID sign-off and withholding unsigned clinical text from answers could leave users without relevant guidance until re-review. Resets the 26 Therapy Compass sign-offs and the DID possession-form specifier to pending review, withholding unsigned clinical prose from site content and clinical answers. Stale retired-rules entry, site-content manifest baseline, and missing 18 Oct ruling decision record have been addressed. ✅ 3 closed✅ Quality: Stale retired-rules entry still says wake-therapy is signed off
✅ Bug: Specifier body change leaves site-content manifest baseline stale
✅ Quality: 18 Oct 00:10 AWST owner ruling cited in code but not in docs/decisions
VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Approved For more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 4 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
|
Code review by qodo was updated up to the latest commit 4e20992 |
User description
Owner ruling (17 Oct 2026, 22:12 AWST): the sign-offs recorded in #3613 for 26 Therapy Compass records and the reworded DID "With/without possession form" specifier were not the owner's. They return to needs review until the owner signs each one with the interactive tool.
Evidence: all 27 were stamped
reviewedBy: "Psych Sift"at the identical round time2026-10-17T12:15:00.000Z, across two different tools.therapy:reviewandclinical:reviewboth need an interactive terminal and stamp the real time with milliseconds.Neither tool has a revoke mode, so this PR resets status in the data (owner-approved). No attestation is recorded or re-pinned:
src/data/therapies-source.json: 26 records →needs_review, checklist unticked, pre-sign-offreviewCompleteness,reviewedBy/reviewedAt/reviewedContentSha256removed (wake-therapy's original nulls restored). The references Complete remaining Therapy Compass sign-offs, DID specifier fix, display.revoke guard, and ledger inbox updates #3613 added stay, sonpm run therapy:reviewoffers all 26.data/specifiers-content.json: DID item →clinician-review-pending,changedSinceReview: true, reviewer/date/pin removed.docs/decisions/2026-10-17-agent-recorded-therapy-and-did-sign-offs-reset.mdrecords the ruling; the Complete remaining Therapy Compass sign-offs, DID specifier fix, display.revoke guard, and ledger inbox updates #3613 decision is marked superseded.donefor #NZ4X41 (b1de924a) and queues an update saying 26 records await owner sign-off.Local runs: typecheck, 86 therapy/specifier/sign-off/site-content test files (1099 tests), plus the ledger, decisions, organisation, index and snapshot checks.
Summary by cubic
Resets the sign-offs recorded in #3613 for 26 Therapy Compass records and the reworded DID possession-form specifier to
needs_review: none were the owner's, so each returns to the sign-off queue until the owner signs it with the interactivetherapy:review/clinical:reviewtools.needs_reviewwith unticked checklists and no reviewer, date, or content pin; the DID specifier returns toclinician-review-pendingwithchangedSinceReviewset.--revoke-previousflag so pre-deploy bundles fall back to the current alias instead of serving the revoked pre-reset generation, and the retired assets are dropped from the change-owner manifest so the change-scope check passes.therapy:reviewwrites the signable projection inside its transaction so a signed therapy leaves the owner's to-do list, andclinical:reviewclearschangedSinceReviewwhen it records a specifier signature.#NZ4X41donein the ledger, and queues an update for the owner to sign each record.Written for commit 4e20992. Summary will update on new commits.
Summary by CodeRabbit
CodeAnt-AI Description
Restore review status and withhold unsigned clinical guidance
What Changed
Impact
✅ Unsigned therapy text excluded from answers✅ 26 therapy sign-offs returned to the owner queue✅ Revoked approvals removed from older catalogue versions💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.