chore(organisation): own the two ingestion tests under source-intake, not app-experience's document-* glob by BigSimmo · Pull Request #3621 · BigSimmo/PsychSift

BigSimmo · 2026-10-17T15:17:34Z

User description

Summary

Two ingestion tests that app-experience's broad tests/document-* glob had claimed now belong to source-intake, the system that owns the code they test:
- tests/document-extraction-source-fidelity.test.ts exercises src/lib/extractors/** and worker/behavior.ts.
- tests/document-detail-demo-window.test.ts exercises src/lib/document-detail.ts.
Explicit source-intake.json entries take precedence over the glob, so app-experience's tests/search-* and tests/document-* globs stay as they are. No ownership check, gate or budget changed.
Of the 73 tests/search-* / tests/document-* tests, 26 already had explicit owners elsewhere. The other 45 that the globs still own test app-experience UI or client code (document viewer, search results, pins, shell, routing) and stay put. No search-* test exercises answer-engine code, so none moved there.
Adds a regression test in tests/maintain-docs-system.test.ts that checks the real manifests: the two tests resolve to source-intake, and viewer and search UI tests stay with app-experience.

Areas touched: Knowledge and records

Verification

Checks run: all 18 Static PR checks steps locally (check:organisation, check:ci-scope, check:knip, format:changed, check:instructions and the rest), all passing; vitest run tests/maintain-docs-system.test.ts tests/organisation-*.test.ts: 423 passed; npm run verify:pr-local passed every step up to typecheck. The shared box ran out of memory there (exit 137), so I re-ran npm run typecheck on its own, which passed (recorded a pass for "typecheck:internal"). Its remaining full unit test step was left to CI.

Risk and rollout

Risk: low. This changes ownership metadata only; no runtime code changed.
Rollback: revert the commit.
Provider or production effects: None

Notes

Left for the owner: tests/document-ingress-safety.test.ts covers ingestion-safety logic, but its subject src/lib/document-ingress-safety.ts is explicitly owned by delivery. Moving only the test would split it from its code, so both should move together if that is wanted.
Follow-up to chore(docs): route domain test paths, anchor landed decisions, and expand AGENTS.md headroom #3610 (built off main after feat(cme,teaching,rag): wire claim-pack surface, registrar milestones, durable dual-sign-off, bookings, and chunking regex hoist (#GR72PF, #XNAHY2, #AD9JC6, #AW8SRK, #54N8ZN, #YETFBJ, #BGDVPD) #3614 and Complete remaining Therapy Compass sign-offs, DID specifier fix, display.revoke guard, and ledger inbox updates #3613 merged).

Summary by cubic

Moves ownership of two ingestion tests from app-experience's broad tests/document-* glob to source-intake, which owns the code they exercise.

tests/document-extraction-source-fidelity.test.ts and tests/document-detail-demo-window.test.ts now have explicit entries in source-intake.json, which take precedence over the glob and leave the other 45 glob-owned UI and client tests with app-experience.
Adds a regression test in tests/maintain-docs-system.test.ts asserting the real manifests resolve these tests to source-intake and viewer/search UI tests stay with app-experience.
No ownership check, gate, or budget changed; no runtime code touched.

^{Written for commit 0c72c05. Summary will update on new commits.}

CodeAnt-AI Description

Assign ingestion tests to source-intake

What Changed

Assign the document extraction and detail tests to source-intake, which owns the code they test.
Keep document viewer and search UI tests with app-experience.
Add checks to prevent these ownership assignments from drifting.

Impact

✅ Ingestion tests counted under source-intake
✅ Viewer and search tests remain with app-experience
✅ Test ownership changes are checked against the manifests

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

… not app-experience's document-* glob tests/document-extraction-source-fidelity.test.ts exercises src/lib/extractors/** and worker/behavior.ts, and tests/document-detail-demo-window.test.ts exercises src/lib/document-detail.ts; source-intake owns all of those. Explicit source-intake entries now take them from app-experience's tests/document-* glob. The other 45 glob-owned search-/document- tests exercise app-experience UI or client code and stay put. Adds a real-manifest ownership regression test.

greptile-apps

BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

codeant-ai · 2026-10-17T15:17:44Z

🤖 CodeAnt AI — Review Status

Status	Commit	Started (UTC)	Finished (UTC)
✅ Reviewed your PR	`0c72c05`	Oct 17, 2026 · 15:17	15:23

codeant-ai · 2026-10-17T15:17:45Z

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

supabase · 2026-10-17T15:17:45Z

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

chatgpt-codex-connector · 2026-10-17T15:17:46Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-17T15:19:08.907884Z	`0c72c05`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-10-17T15:17:47Z

Warning

Review limit reached

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Next included review available in 7 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 114 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: BigSimmo/PsychSift/.coderabbit.yaml
Review profile: CHILL
Plan: Team
Run ID: 2c499d28-d666-4b8d-bfe6-9a6b82e823ee

📥 Commits

Reviewing files that changed from the base of the PR and between afd6fda and 0c72c05.

📒 Files selected for processing: 2

docs/organisation/systems/source-intake.json
tests/maintain-docs-system.test.ts

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

claude · 2026-10-17T15:18:08Z

Claude encountered an error after 2s —— View job

I'll analyze this and get back to you.

qodo-code-review · 2026-10-17T15:18:10Z

PR Summary by Qodo

Assign two ingestion tests to source-intake

⚙️ Configuration changes 🧪 Tests 🕐 10-20 Minutes

AI Description

• Assign two ingestion tests to source-intake, matching ownership of the code they exercise.
• Keep app-experience’s document and search globs unchanged; test both ownership outcomes against
 real manifests.

Diagram

graph TD
  I["Ingestion tests"] --> S["Exact source entries"] --> C["Path classifier"] --> O["Source intake"]
  U["UI tests"] --> G["App experience globs"] --> C --> A["App experience"]

High-Level Assessment

Explicit entries are the narrowest way to align these tests with their subjects without disturbing the broader UI test globs. Narrowing those globs would create substantially more ownership changes for no demonstrated benefit.

Files changed (2) +17 / -0

Tests (1) +15 / -0

maintain-docs-system.test.tsGuard real-manifest test ownership +15/-0

Guard real-manifest test ownership

• Asserts that both ingestion tests resolve to source-intake and representative document-viewer and search UI tests continue to resolve to app-experience.

tests/maintain-docs-system.test.ts

Other (1) +2 / -0

source-intake.jsonClaim two ingestion tests explicitly +2/-0

Claim two ingestion tests explicitly

• Adds exact paths for the document-detail demo-window and extraction source-fidelity tests. These entries override app-experience’s broad document-test glob without changing that glob.

docs/organisation/systems/source-intake.json

gitar-bot · 2026-10-17T15:18:21Z

Code Review ✅ Approved

🟢 Low risk · The manifest adds explicit test ownership entries and a regression assertion; these affect repository organization only, leaving runtime behavior unchanged.

Moves the tests/document-extraction-source-fidelity.test.ts and tests/document-detail-demo-window.test.ts ingestion tests from app-experience's broad tests/document-* glob to source-intake, which owns the code they exercise. Explicit source-intake.json entries take precedence, and viewer and search UI tests stay with app-experience. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Approved

_{For more verification details, comment gitar display:verbose.}

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

`Auto-apply`	`Compact`
`gitar auto-apply:on`	`gitar display:verbose`

Important

Your trial ends in 4 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

_{Was this helpful? React with 👍 / 👎 | Gitar}

codeant-ai · 2026-10-17T15:18:22Z

🏁 CodeAnt Quality Gate Results

Commit: 0c72c05d
Scan Time: 2026-10-17 15:32:41 UTC

✅ Overall Status: PASSED

Quality Gate Details

Quality Gate	Status	Details
Secrets	✅ PASSED	0 secrets found
Duplicate Code	✅ PASSED	0.0% duplicated
SAST	✅ PASSED	No security issues
Bugs	✅ PASSED	Rating S: No bugs
IAC	✅ PASSED	No IAC issues

View Full Results

gitar-bot

Gitar has auto-approved this PR (configure)

qodo-code-review · 2026-10-17T15:21:11Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can see how risky a PR is at a glance with blast radius labels

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

qodo-code-review · 2026-10-17T15:21:17Z

Qodo Fixer

No findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR.

codeant-ai · 2026-10-17T15:23:56Z

CodeAnt PR Risk: Low Risk

The PR appears safe to merge; it assigns two ingestion tests to source-intake and adds assertions for their ownership.

Assessed commit: 0c72c05dc87b

BigSimmo enabled auto-merge (squash) October 17, 2026 15:17

greptile-apps Bot reviewed Oct 17, 2026

View reviewed changes

codeant-ai Bot added the size:S This PR changes 10-29 lines, ignoring generated files label Oct 17, 2026

qodo-code-review Bot added the 🕐 10-20 Minutes label Oct 17, 2026

gitar-bot Bot approved these changes Oct 17, 2026

View reviewed changes

qodo-code-review Bot added the 🟡 Small blast radius label Oct 17, 2026

BigSimmo merged commit 98a6f6d into main Oct 17, 2026
43 of 45 checks passed

BigSimmo deleted the test-ownership-search-ingest-20261017 branch October 17, 2026 15:32

github-actions Bot mentioned this pull request Oct 17, 2026

CI on main is failing #3099

Open

BigSimmo mentioned this pull request Oct 17, 2026

chore(organisation): place tests/chunking-regex-hoist.test.ts under source-intake #3626

Merged

1 task done

Conversation

BigSimmo commented Oct 17, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

Summary

Verification

Risk and rollout

Notes

Summary by cubic

CodeAnt-AI Description

What Changed

Impact

Checking Your Pull Request

Talking to CodeAnt AI

Example

Preserve Org Learnings with CodeAnt

Example

Retrigger review

Check Your Repository Health

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

codeant-ai Bot commented Oct 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 CodeAnt AI — Review Status

Uh oh!

codeant-ai Bot commented Oct 17, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

supabase Bot commented Oct 17, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Oct 17, 2026

Review limit reached

Uh oh!

claude Bot commented Oct 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qodo-code-review Bot commented Oct 17, 2026

PR Summary by Qodo

Uh oh!

gitar-bot Bot commented Oct 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codeant-ai Bot commented Oct 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🏁 CodeAnt Quality Gate Results

✅ Overall Status: PASSED

Quality Gate Details

Uh oh!

gitar-bot Bot left a comment

Choose a reason for hiding this comment

Uh oh!

qodo-code-review Bot commented Oct 17, 2026

Code Review by Qodo

Great, no issues found!

Uh oh!

qodo-code-review Bot commented Oct 17, 2026

Qodo Fixer

Uh oh!

codeant-ai Bot commented Oct 17, 2026

CodeAnt PR Risk: Low Risk

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BigSimmo commented Oct 17, 2026 •

edited by cubic-dev-ai Bot

Loading

codeant-ai Bot commented Oct 17, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 17, 2026 •

edited

Loading

claude Bot commented Oct 17, 2026 •

edited

Loading

gitar-bot Bot commented Oct 17, 2026 •

edited

Loading

codeant-ai Bot commented Oct 17, 2026 •

edited

Loading