Repository navigation
chore(ledger): reconcile 21 pending inbox requests and record prlanded proofs - #3609
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 49 minutes. View limit details
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Code Review by Qodo
No findings for this group No findings for this group 1. The form review closes with wording left
|
codeant-ai
Bot
added
the
size:L
PR Summary by QodoReconcile 21 issue requests and record three landed-PR proofs
AI Description
Diagram
High-Level Assessment
Files changed (28)
|
Qodo FixerNo findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR. |
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11bee2d17e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
CodeAnt PR Risk: Low Risk
Assessed commit: |
|
Code review by qodo was updated up to the latest commit 964eff3 |
Code Review ✅ Approved 2 closed / 2 findings🔴 High risk · Risk could not be assessed, so high risk was applied as a precaution. Reconciles the pending inbox requests into the outstanding-issues ledger and records prlanded proofs for PRs #3567, #3570, and #3573, with follow-up requests queued for the unfinished parts of #08216B, #WMGPSG, and #1WAA0Z. Changes requested: #WFYDV6 was closed as a P1 statutory-text issue without legal/clinical sign-off, and the ✅ 2 closed✅ Bug: Multi-part issues closed when only some parts are done; open work lost
Closed: Bug: P1 statutory-text issue #WFYDV6 closed without legal/clinical sign-off
VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Approved For more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 4 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
|
Code review by qodo was updated up to the latest commit 7aac5a0 |
|
Proof note (sweep 17 Oct): the #3570 prlanded record added here (docs/branch-review-records/a7be2760…record.md) names branch |
…, durable dual-sign-off, bookings, and chunking regex hoist (#GR72PF, #XNAHY2, #AD9JC6, #AW8SRK, #54N8ZN, #YETFBJ, #BGDVPD) (#3614) * feat(cme,teaching,rag): wire claim-pack surface, registrar milestones, durable dual-sign-off, bookings, and chunking regex hoist (#GR72PF, #XNAHY2, #AD9JC6, #AW8SRK, #54N8ZN, #YETFBJ, #BGDVPD) * chore(issues): queue follow-up inbox items from PR #3609 review (#08216B, #WFYDV6, #WMGPSG, #1WAA0Z) * chore(issues,ledger): queue Stage 2 done/update inbox records and PR #3609 prlanded record * fix(tests): align eslint-disable comments in Stage 2 test files * fix: 8 findings — Authorize booking creation and access; Authorize train - Authorize booking creation and access - Authorize trainees before booking - Guard cancellation against stale state - Scope open booking availability - Add optimistic assessment concurrency protection - Validate IDs and sanitize database errors - Push booking filters into durable queries - Always enforce teaching rate limits * fix: 7 findings — Stop mirroring ordinary milestones as EPAs; Deduplicat - Stop mirroring ordinary milestones as EPAs - Deduplicate milestones by stable identity - Apply the current rotation FTE target - Remove fabricated rotation deadlines - Use the current rotation deadline - Avoid invented WBA totals - Check registrar synchronization results * fix: 2 findings — Preserve registrar fetch failures; Avoid duplicate reg - Preserve registrar fetch failures - Avoid duplicate registrar milestone fetches * fix(teaching,cme): repair Qodo auto-fix build/format breaks and address review threads Teaching assessments: - Declare range() on the registrar_assessments filter builder and page booking lists instead of an undeclared, row-dropping .limit(500) (TS2339 in Build). - Supervisor access via work_can('assessments.review') instead of a teaching_member_roles 'supervisor' role the schema does not allow. - create_draft / supervisor_sign_off verify trainee membership and that the named supervisor can review that trainee (no arbitrary sign-off accounts). - Re-check overlaps after inserting a slot; the later of a concurrent pair withdraws itself. - In-memory stores mint UUIDs to match the uuid route validation; tests mock the always-on rate limit and the membership/work_can surface. CME training: - Generic registrar milestones (exams, psychotherapy cases, CME mirrors) no longer appear as EPAs; WBA counts stay unrecorded rather than invented. - Rotation deadline is the current rotation's end (Perth date) or none. - Restore write mirroring for real clients (Qodo had disabled it) while checking each sync result; edit/delete fall back to registrar-only rows. - Prettier on the four files the bot commits left unformatted. --------- Co-authored-by: qodo-code-review[bot] <151058649+qodo-code-review[bot]@users.noreply.github.com> Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
User description
Summary
pm run issues:reconcile\ (\108 open, 0 pending).
Verification
ode scripts/check-ledger-write-discipline.mjs\ — PASS
ode scripts/check-outstanding-issues-snapshot.mjs\ — PASS
pm run docs:maintain\ — PASS
Summary by cubic
Reconciles all 21 pending inbox requests into the outstanding-issues ledger, bringing pending to zero, and queues follow-up requests for the unfinished parts of #08216B, #WMGPSG, and #1WAA0Z raised in the PR #3609 review.
Also records
prlandedproofs for PRs #3567, #3570, and #3573 and updates the branch review index and repo-awareness snapshot accordingly.This is a documentation-only change; no application code is touched. The ledger snapshot now shows 108 open issues with 0 pending, and all reconciliation, snapshot, and docs maintenance checks pass.
Written for commit 7aac5a0. Summary will update on new commits.
CodeAnt-AI Description
Reconcile the issue inbox and update the project review records
What Changed
Impact
✅ 0 pending issue requests✅ Issue ledger updated to 108 open items✅ Merge proofs recorded for 3 PRs💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.