Repository navigation
Let clinical:review sign sources reviewed only in prose (OCP WA standards) #3607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gitar-bot
merged 8 commits into
main
from
fix/clinical-review-unsigned-reviewed-sources
Oct 17, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f89a156
clinical:review: let the owner sign sources reviewed only in prose
BigSimmo 755f166
fix: 2 findings — Count stale attestations as signable; Reuse acquisitio
qodo-code-review[bot] e0f898b
style: Prettier on sign-off-queue.ts after the review-bot fix
BigSimmo 51b8840
Address review: decision entry, complete-attestation stale rule, accu…
BigSimmo 9537859
Merge remote-tracking branch 'origin/main' into fix/clinical-review-u…
BigSimmo a6e0854
chore: refresh repo-awareness snapshot for the new decision entry
BigSimmo 0ae8329
Address review: empty attestation fields reported, accurate re-sign copy
BigSimmo 72361c2
Merge remote-tracking branch 'origin/main' into fix/clinical-review-u…
BigSimmo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
docs/decisions/2026-10-17-sign-prose-only-source-reviews.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # Decision: The owner can sign sources reviewed only in prose | ||
|
|
||
| - **Status:** decided 2026-10-17 | ||
| - **Source:** `scripts/lib/signoff-kinds/sources.mjs`, find "The owner may sign it with this tool like a drafted source" | ||
| - **Retires:** `clinical-review-signs-only-unverified-sources` | ||
|
|
||
| `npm run clinical:review -- --kind source` now also offers a source that is marked `locally_reviewed`, is not | ||
| rejected, and has no attestation field at all, because its review was recorded only in prose. Signing it | ||
| writes attestedBy, attestedAt and attestedAgainstSha256 and leaves validationStatus as it is. Sources with | ||
| any attestation field, approved or rejected sources, and Indigenous content are still not offered this way. | ||
| The interactive-terminal requirement and the full-name signer rule are unchanged. The owner approved this | ||
| in chat on 17 Oct 2026 so they can sign the two OCP WA standards themselves. | ||
|
|
||
| If this summary and the source ever differ, the source wins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.