Repository navigation
Answer page tidy-up: amber line under a shorter notice, square chips, plain rows #3605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d4d2b2c
Answer page tidy-up: warning line under notice, shorter notice, squar…
claude 8bf90c0
Test: provider failure moves to the amber line under the overseas notice
claude ef18650
Test: an evidence reason keeps its sentence above a source-only answer
claude 7a5221d
Render How this answer was built above the library row, inside the su…
claude d3935ff
Decision record: one Source anchor in the expected format
claude d4fcad7
Regenerate repo-awareness snapshot
claude a80c333
fix: 2 findings — Distinguish retrieval and generation timeouts; Associa
qodo-code-review[bot] fa458cf
Keep the retrieval deadline warning above the answer
claude 1bfc7b9
Merge the review bot's commit, keeping its build-history fix only
claude 2bcef8a
Capture answer build history before the final payload lands
claude c1f00bb
Don't promise verified passages when no source came back
claude 5b256cf
Keep the home overseas notice in the future tense
claude f922d5e
Merge main into the Answer page tidy-up branch
claude 2d59ae8
Merge branch 'main' into claude/answer-page-tidy-7cbf5h
BigSimmo abb6abf
Merge branch 'main' into claude/answer-page-tidy-7cbf5h
BigSimmo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Decision: Answer page tidy-up and a shorter overseas notice | ||
|
|
||
| - **Status:** decided 2026-10-17 | ||
| - **Source:** `src/components/clinical-dashboard/answer-provider-notice.tsx`, find "AnswerSummaryUnavailableNotice" | ||
|
|
||
| The owner approved a mockup of the Answer page and asked for it to be built. The overseas notice under an answer now reads "Sent to OpenAI overseas. Don't include patient details." and is centred. The line no longer shows on the Answer home at all ([the home-page decision](2026-10-17-no-overseas-line-on-home-pages.md)), so it only appears once a question has been sent. When the model could not write the answer, an amber "AI summary unavailable" line sits directly under that notice instead of a sentence above the question. Other degraded reasons, which say something about the evidence, keep their sentence above the answer. The limitations chip drops its count when it already says "Source-only" or "Review due", and the support and limitations chips share one square shape and size. "How this answer was built" moved under the answer's actions, and "Also in your library" became a plain row with its count shown at every width. | ||
|
|
||
| If this summary and the source ever differ, the source wins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
src/components/clinical-dashboard/answer-build-details.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import { ChevronDown, ListTree } from "lucide-react"; | ||
|
|
||
| import { | ||
| answerProgressDisplayMessage, | ||
| answerProgressTookUnusualRoute, | ||
| type TimedAnswerProgressUpdate, | ||
| } from "@/components/clinical-dashboard/answer-progress"; | ||
|
|
||
| /** | ||
| * "How this answer was built", as a row under the answer's actions (owner decision, 17 Oct 2026). | ||
| * It used to sit above the question as a small triangle link, which put a footnote first. | ||
| * | ||
| * Still only offered when the answer did not take the ordinary route. A routine answer has | ||
| * nothing to disclose, and the retired panel offered the same five stages every time. | ||
| */ | ||
| export function AnswerBuildDetails({ events }: { events: TimedAnswerProgressUpdate[] }) { | ||
| if (events.at(-1)?.stage !== "complete" || !answerProgressTookUnusualRoute(events)) return null; | ||
| const details = events | ||
| .map((event) => ({ ...event, displayMessage: answerProgressDisplayMessage(event) })) | ||
| .filter((event, index, all) => index === 0 || event.displayMessage !== all[index - 1]?.displayMessage) | ||
| .slice(-8); | ||
| return ( | ||
| <details data-testid="answer-build-details" className="group min-w-0 border-t border-[color:var(--border)]"> | ||
| <summary className="flex min-h-12 cursor-pointer list-none items-center gap-2.5 rounded-md text-sm font-medium text-[color:var(--text-heading)] focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-[color:var(--focus)] [&::-webkit-details-marker]:hidden"> | ||
| <span | ||
| aria-hidden="true" | ||
| className="grid h-7 w-7 shrink-0 place-items-center rounded-md border border-[color:var(--border)] bg-[color:var(--surface-raised)] text-[color:var(--text-muted)] forced-colors:border" | ||
| > | ||
| <ListTree className="size-icon-md" aria-hidden="true" /> | ||
| </span> | ||
| <span className="min-w-0 flex-1">How this answer was built</span> | ||
| <ChevronDown | ||
| aria-hidden="true" | ||
| className="size-icon-md shrink-0 text-[color:var(--text-muted)] transition-transform group-open:rotate-180 motion-reduce:transition-none" | ||
| /> | ||
| </summary> | ||
| <ol className="mb-3 ml-3.5 space-y-1 border-l border-[color:var(--border)] pl-3 text-2xs text-[color:var(--text-muted)]"> | ||
| {details.map((event, index) => ( | ||
| <li key={`${event.receivedAt}-${event.stage}-${index}`} className="leading-relaxed"> | ||
| {event.displayMessage} | ||
| </li> | ||
| ))} | ||
| </ol> | ||
| </details> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.