Repository navigation
Stop a note under a recovered table row being glued into that row - #3595
Conversation
A lone line beneath a row recovered from a table's edge strip was merged into the row's cell whenever it sat within 16pt. A short note such as 'See note' under 'Clozapine' became 'Clozapine See note'. Now the line joins the row only when the cell above actually wrapped: its text must reach closer to the column's right edge than the width of the next line's first word. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M6gRtN6r4vZDgDfzMtjs95
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 30 minutes. View limit details
Comment |
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
A dose written under a drug name, or a bulleted step, does not reach the column's right edge, so the wrap check dropped it. A line that starts at the cell's own left edge with a bullet, a lower-case word or a number now joins the cell too. A capitalised note such as 'See note' still stays out. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M6gRtN6r4vZDgDfzMtjs95
A footnote flush with the first cell, such as '* Off-label use' or '1 Not PBS listed', matched the deliberate-break rule and was glued into the row. '*' no longer counts as a continuation marker, and a leading number counts only when the next word is not capitalised, so doses like '1 to 2 mg' still join. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M6gRtN6r4vZDgDfzMtjs95
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
🤖 CodeAnt AI — Review Status
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
codeant-ai
Bot
added
the
size:L
PR Summary by QodoPrevent notes below recovered PDF table rows from merging into cells
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44657fe61d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A short right-aligned value (a score of 5) ends near the column's right edge without having wrapped, so a note under it was still joined. The wrap test now counts the free space on either side of the line above. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M6gRtN6r4vZDgDfzMtjs95
Qodo FixerNo findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR. |
CodeAnt Nitpicks1 code suggestion1. A lowercase note aligned with the preceding cell is always joined, even when that cell's text ends far from the column edge, corrupting the extracted table.Incorrect condition logic · |
CodeAnt PR Risk: Medium Risk
Assessed commit: |
Code Review by Qodo
No findings for this group No findings for this group No findings for this group Resolved findings 1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
A row whose cells start on staggered baselines had its later cell dropped by the new note check, because that column had no line above it to compare against. A lone line now fills a still-empty cell as it did before; the note check applies only to cells that already hold text. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M6gRtN6r4vZDgDfzMtjs95
|
Replies to the Qodo review on acc2338:
Generated by Claude Code |
Code Review ✅ Approved 2 closed / 2 findings🟡 Medium risk · Changing recovered-row continuation heuristics could omit legitimate wrapped cell text or retain notes in extracted tables for newly indexed PDFs. Stops short notes under a recovered table row from being merged into that row's cells, so a line joins the row above only when that cell actually wrapped or starts with a bullet, lower-case word, or number. No open issues remain. Hard line breaks inside cells are now dropped from recovered rows, and footnotes starting with '*' or a digit are no longer glued back into the row. ✅ 2 closedClosed: Edge Case: Hard line breaks inside cells are now dropped from recovered rows
Closed: Bug: Footnotes starting with '*' or a digit get glued back into the row
VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Approved For more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 4 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
|
Code review by qodo was updated up to the latest commit d5dfe96 |
|
Comment audit against head d5dfe96. All 7 review threads are resolved with replies. Dispositions for the items outside threads:
Note for the owner: this PR changes Generated by Claude Code |
User description
Summary
find_tablescut off, any short line just under that row was merged into one of its cells. A note such as "See note" under "Clozapine" became "Clozapine See note" in the table, the accessible table text and the table facts.tests/pdf-table-extraction.test.ts. This PR fixes the leftover. The update request downgrades it to P2 and records what is still open: text laid out in the table's own columns directly beneath it (for example an abbreviation key) can still become a row when a drawing extends the crop over it.Areas touched: Source intake and indexing, Knowledge and records
RAG impact: no retrieval behaviour change — extractor output only changes for documents ingested or re-indexed after merge; live chunks, embeddings and ranking are untouched until then.
Verification
Tests 1 failed | 4 passed (5)) and passes with it.npx vitest run tests/pdf-table-extraction.test.ts tests/pdf-extractor.test.ts:Tests 10 passed | 1 skipped (11).python3 -m unittest discover -p "test_extract_pdf_assets*.py"inworker/python:Ran 53 tests ... OK.npm run test:focused, eslint--max-warnings 0,docs:check-linkspassed.Risk and rollout
Notes
Generated by Claude Code
Summary by cubic
Stops a short note under a recovered table row being merged into that row's cells. A lone line now joins the row above only when that cell actually wrapped (free space is counted on both sides, covering right-aligned and centred cells) or when the line starts at the cell's left edge with a bullet, lower-case word, or number (a dose under a drug name); otherwise it stays out of the table.
Bug Fixes
* Off-label useand1 Not PBS listed. Tests intests/pdf-table-extraction.test.tscover all cases.Written for commit d5dfe96. Summary will update on new commits.
CodeAnt-AI Description
Keep notes and footnotes out of recovered PDF table rows
What Changed
Impact
✅ Fewer notes shown inside PDF table cells✅ Preserved multi-line doses and instructions in extracted tables✅ Cleaner table text in newly indexed PDFs💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.