Repository navigation
Make Cloud instructions current and harden environment setup - #3593
Conversation
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
🤖 CodeAnt AI — Review Status
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d86e86fa2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Auto-fix isn't included in your plan ↗ |
Code Review by Qodo
No findings for this group 1. Offline Cloud checks reject a mode setup ignores
|
PR Summary by QodoMake Cloud instructions current and harden environment setup
AI Description
Diagram
High-Level Assessment
Files changed (98)
|
CodeAnt Nitpicks2 code suggestions1. When the cache file is absent or invalid, this branch leaves an inherited SHA untouched; an old but reachable commit can make the checkout appear fresh against the wrong base.Stale reference · 2. The docs index still labels this and the two parallel prompts “Codex Local Ultra,” contradicting their new headings and implying a special host mode they do not require.Inconsistent naming · |
Qodo Fixer✅ Committed (3) · ☑ Fixed (3) Commits pushed directly to this PR — no separate fix PR opened. Process — 3 fixed
|
|
Code review by qodo was updated up to the latest commit 59ad331 |
Code Review ✅ Approved 2 closed / 2 findings🔴 High risk · Cloud checkout/profile admission and GitHub authentication preflight change access decisions, which could allow unintended remote operations or block legitimate tasks. Makes Cloud instructions current and hardens Codex and Claude Cloud setup, diagnostics, GitHub authentication preflight, profile seeding and checkout validation. Two issues were resolved: maintenance now accepts the same ✅ 2 closed✅ Edge Case: Maintenance rejects RAG_PROVIDER_MODE values that setup accepts
✅ Bug: Cloud host-signal check fails existing test and contradicts the workflow docs
VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Approved For more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 5 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
|
Code review by qodo was updated up to the latest commit 3af32df |
Summary
Cloud tasks could reload obsolete launch rules and session memories, while setup helpers accepted invalid inputs or reported stale readiness. Consolidate current-host instructions, archive completed prompts and old session state, and make legacy bootstrap validation explicitly selected.
Harden Codex and Claude Cloud setup, diagnostics, GitHub authentication preflight, profile seeding and checkout validation. Preserve existing host memories, provider/production safeguards and specialist programme evidence. Retain the owner-approved restricted continuation and scrubbed offline-check policy from #3581.
Areas touched: Knowledge and records, Delivery and assurance
RAG impact: no retrieval behaviour change — changes cover launch guidance, phase admission and generated package metadata; phase routing, receipts and independent review requirements remain intact.
Verification
npm run formatcompleted; normal commit hooks synchronized applicable generated documentation.3af32df42c2dfbefd75a0fff9820ebc2c4c8a316; no actionable findings remain.check:dead-code-candidatereturned diagnostic findings for one obsolete export without callers and two private helpers replaced by the tested checkout validator and strict argument parser. These are reviewed behavioral replacements, not module deletions justified by reachability alone; the diagnostic scan is not reported as passing.GitHub CI on
3af32df42c2dfbefd75a0fff9820ebc2c4c8a316is green: run 38945349618, including thePR requiredaggregate. Both coverage partitions passed 31,782 unit tests in total (one historical skip). Static checks, lint/typecheck, safety, both builds, critical browser checks and all three full browser shards passed. SAST and secret scanning also passed. Workflow-selected skips are recorded as skips, not passing evidence.Not run locally: application browser/release gates and provider-backed clinical evaluations. CI completed its scope-selected build and browser checks. No live-service mutation, actual-home provisioning or credential-value inspection was used in local verification.
Risk and rollout
Notes
This PR uses a separate branch from #3587, which merged during publication; its changes are integrated here without overwriting that work. The earlier legacy runbook and seven session records are retained as labelled history rather than active startup instructions.