Repository navigation
Design follow-ups: On Call hospital change in the hero, square Clinical chips, readable small labels - #3564
Conversation
…ne, square Clinical chips, 12 px legends, Work search and safety plan polish Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TexgR3MMbRJjXTT2C5PoPw
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 40 minutes. View limit details
✨ Finishing Touches
Comment |
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
🤖 CodeAnt AI — Review Status
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
codeant-ai
Bot
added
the
size:L
PR Summary by QodoPolish Work heroes, Clinical chips, and small-label readability
AI Description
Diagram
High-Level Assessment
Files changed (22)
|
Code Review by Qodo
No findings for this group No findings for this group No findings for this group Resolved findings 1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
- Preserve the search coach note for the current visit - Only mark visible desktop search guidance as seen
Qodo Fixer✅ Committed (3) · ☑ Fixed (3) Commits pushed directly to this PR — no separate fix PR opened. Process — 3 fixed
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found and verified against the latest diff
Confidence score: 4/5
my-day-today-cards.tsxstill renders the legend at 12px becausetext-2xsandtext-xsresolve to the same size. Use a genuinely larger type token if the labels are meant to grow.roster-month-grid.tsxhas the same issue:text-3xsandtext-xsboth resolve to 12px, so the month legend does not get larger. Use a genuinely larger type token if that is the intent.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/components/my-day/my-day-today-cards.tsx">
<violation number="1" location="src/components/my-day/my-day-today-cards.tsx:869">
P3: This class change does not increase the legend text size because both `text-2xs` and `text-xs` resolve to 12px here. Use a genuinely larger type token if this follow-up is meant to enlarge the labels.</violation>
</file>
<file name="src/components/roster/roster-month-grid.tsx">
<violation number="1" location="src/components/roster/roster-month-grid.tsx:140">
P3: This class change does not increase the month legend text size because both `text-3xs` and `text-xs` resolve to 12px here. Use a genuinely larger type token if the labels are intended to become larger.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
Auto-fix isn't included in your plan ↗ |
CodeAnt Nitpicks3 code suggestions1. In large-text mode, the shared stylesheet disables line clamping and exposes overflow. A long single-word name then spills across neighboring tiles because wrapping is disabled.Css layout issue · 2.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d8c36a77c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CodeAnt PR Risk: Low Risk
Assessed commit: |
…wed; square Formulation prompt chips Storing the note as read the moment it appeared hid it at the next re-render, because the stored value is read on every render. It is now stored when it goes (timer, tap, key or scroll), and only at desktop width, where the note is on screen, so a phone visit that shows only the ring does not use it up. Formulation's "Try another pattern" chips take the Clinical control corners like the other Clinical prompts. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TexgR3MMbRJjXTT2C5PoPw
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TexgR3MMbRJjXTT2C5PoPw
|
Qodo findings handled in f6d298e:
Qodo also pushed its own fix for these (9d4da4a, d08426b). It was merged in, but the work search button keeps the version above. Qodo's version set state inside an effect and called Generated by Claude Code |
Thanks for the update. The current review shows all three findings as resolved:
The changes in |
|
Code review by qodo was updated up to the latest commit f6d298e |
… as the owner's decision, real one-hospital test - Favourites: at large text the two-line clamp lifts, so a long single word may break there rather than spill past its tile. - Admin: the page comment still said the owner had dropped the date line. The owner brought it back on 16 Oct 2026 after seeing the picture; comment updated and the decision indexed in docs/decisions. - On Call: the "only one hospital" test now gives the reader exactly one hospital, not none. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TexgR3MMbRJjXTT2C5PoPw
|
Code review by qodo was updated up to the latest commit 09d6244 |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TexgR3MMbRJjXTT2C5PoPw
Code Review ✅ Approved🟡 Medium risk · The search coach now disappears and persists after interaction, so users could miss its guidance; hospital selection also moves into the hero. Design follow-up PR that moves the On Call hospital change action into the hero, squares Clinical chip corners, raises small hero and legend labels to 12 px at full contrast, and adds the Admin date line. No issues found. VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Approved For more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 5 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
|
Code review by qodo was updated up to the latest commit f5be679 |
User description
Summary
Before: On Call named the hospital twice, once in the summary card and again on a line below that held the Change button. Some Clinical chips (the search prompt chips and the "Show all" chip) were rounded pills, a Work-mode shape. Small labels on the CPD and Admin heroes, the My Day ring legend and the Roster legend were faint or 10 px. Admin had no date line over its title. Favourites could split a drug name mid-word ("Acamprosa te"). The safety plan's step counts looked like empty boxes to type into. The Work search "New" note could sit over CPD's Customise button until dismissed.
After: On Call's hero carries a quiet "Change hospital" pill, and the duplicate hospital line is gone. Clinical chips use the Clinical square-ish corners, and Work keeps its pills. Hero and legend labels are 12 px at full contrast. Admin shows the date line like every other Work page. Favourites names wrap only at spaces and end in an ellipsis. Safety plan counts are a quiet tinted number that a screen reader hears as "3 entries". The Work search note shows once per device and goes by itself after 8 seconds, or at the first tap, key or scroll.
These are the agreed follow-ups from the 15 Oct 2026 design critique. Presentation only, with no clinical content, data, auth or provider changes. Josh saw the before and after picture and approved it on 16 Oct 2026.
Areas touched: Personal practice, App experience, Answer engine
RAG impact: no retrieval behaviour change.
answer-suggestion-chips.tsxgains a corner-shape option only. No ranking, retrieval or ordering file was touched.Verification
TSC_EXIT 0. ESLint clean on every changed file. Prettier: "All matched files use Prettier code style!"npm run test:focusedon all 22 changed files: "Test Files 112 passed (112)", "Tests 1419 passed (1419)".Risk and rollout
Notes
🤖 Generated with Claude Code
https://claude.ai/code/session_01TexgR3MMbRJjXTT2C5PoPw
CodeAnt-AI Description
Improve clarity across On Call, Clinical tools, and Work pages
What Changed
Impact
✅ Hospital changes without duplicate hospital names✅ Easier-to-read Work page labels✅ Favourite names stay intact✅ Search tip clears the page automatically💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by CodeRabbit
New Features
Style
Bug Fixes