Repository navigation
Design: fix layout bugs across Clinical and Work, add On Call and Roster summary cards - #3559
Conversation
…ter summary cards CPD Log an activity moves into the summary card, Log page keeps room for the bar, Customise stays in the gutter, today segment no longer splits. DSM Compare stacks on phones, DSM results leave room for the composer, empty differential sections say None listed, Services uses Browse rows, Formulation builder drops its repeat eyebrow. On Call timeline labels no longer collide, roster label uses Geist, emergency number keeps together, Teaching name wraps, My Day ring shows percent done, Favourites names hyphenate. On Call and Roster open with the approved summary card. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TexgR3MMbRJjXTT2C5PoPw
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 36 minutes. View limit details
📝 Walkthrough
Merge Risk: 🟡 Moderate · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 52.63% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 19 functions across 25 files. (2 skipped:… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Title check The title clearly summarizes the main changes: mobile layout fixes across Clinical and Work, plus new On Call and Roster summary cards. Description check The description is complete and relevant. It includes a detailed summary, areas touched, RAG impact, governance checks, verification results including the known flaky test, risk, rollback, production …
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 52.63% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 19 functions across 25 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TexgR3MMbRJjXTT2C5PoPw
…gn-system contract Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TexgR3MMbRJjXTT2C5PoPw
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
codeant-ai
Bot
added
the
size:L
PR Summary by QodoFix mobile layouts and add On Call and Roster summary cards
AI Description
Diagram
High-Level Assessment
Files changed (28)
|
Code Review by Qodo
No findings for this group No findings for this group No findings for this group Resolved findings 1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
- Show the selected calling route - Show a neutral title while data loads
Qodo Fixer✅ Committed (7) · ☑ Fixed (7) Commits pushed directly to this PR — no separate fix PR opened. Process — 7 fixed
|
|
Code review by qodo was updated up to the latest commit f266cfe |
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
CodeAnt PR Risk: Low Risk
Assessed commit: |
…ft when the read fails Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TexgR3MMbRJjXTT2C5PoPw
|
Code review by qodo was updated up to the latest commit ea09761 |
…er the dock hides The reveal ran on focusin and one frame later. The reveal scroll hides the dock, the shell reserve then animates to zero, and late sections above the results can still grow, which carried an already-revealed control back off screen (ui-overlap phone Tab test, intermittent on main). Watch the content box for a short settle window and re-reveal on each resize. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TexgR3MMbRJjXTT2C5PoPw
|
Code review by qodo was updated up to the latest commit 5f86d76 |
…ps re-revealing once the reader scrolls Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TexgR3MMbRJjXTT2C5PoPw
|
Code review by qodo was updated up to the latest commit 176d3c3 |
…page jump link is not scrolled back to the link Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TexgR3MMbRJjXTT2C5PoPw
Code Review ✅ Approved 3 closed / 3 findings🟡 Medium risk · The new roster-aware switchboard pill initiates a phone call on activation, so an accidental tap could dial the hospital unexpectedly. Adds On Call and Roster summary cards and fixes phone layout bugs across Clinical and Work, including the CPD log bar, DSM Compare slots, and On Call timeline labels. The CPD Year page keeps its Log button when entries total 0 h, the empty-section pointer no longer names a missing heading, and the settle observer no longer pulls the page back after the user scrolls away. No issues remain open. ✅ 3 closed✅ Edge Case: CPD Year page loses its only Log button when entries total 0 h
✅ Bug: Empty-section pointer names a 'key distinction' heading that doesn't exist
✅ Edge Case: Settle observer can pull the page back after the user scrolls away
VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Approved For more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Important Your trial ends in 6 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
|
Code review by qodo was updated up to the latest commit af15fbe |
User description
Summary
Before: on a phone, the CPD "Log an activity" bar covered list rows. DSM Compare slots ran off the screen. On Call timeline labels collided ("17:00Now"), and its emergency number wrapped badly. The Teaching series name was cut off, My Day showed the time left twice, and Favourites names split mid-word. Empty differential sections looked tappable, and Services showed a bare link. On Call and Roster had no Work summary card.
After: each of those is fixed. On Call and Roster now open with the owner-approved bold summary card, with a white pill main action (Call switchboard, Who's on).
These come from the owner-reviewed design critique of 15 Oct 2026, limited to the items marked "likely mistakes". Items marked "could be deliberate" are unchanged. Clinical home stays centred, and Clinical buttons keep their corners.
on-call-hero.tsx. The Roster month strip is replaced by the hero card, and shared hero pill styles are added inwork-mode.css.Areas touched: Personal practice, App experience
RAG impact: no retrieval behaviour change. No ranking, retrieval or search-ordering file was touched.
Clinical Governance Preflight
PsychSift Production(sjrfecxgysukkwxsowpy)Verification
npm run verify:cheap: lint and typecheck clean. Unit suite gave "Test Files 1 failed | 1882 passed (1883)".tests/my-day-week.dom.test.tsx, "shows a signed-out reader the sample week". It is afindByTestIdtimeout under load. Rerun alone three times: 23 passed, 23 passed, 1 failed. It doesn't import any changed file, so it's a pre-existing flake.Risk and rollout
Notes
🤖 Generated with Claude Code
https://claude.ai/code/session_01TexgR3MMbRJjXTT2C5PoPw
Generated by Claude Code
Summary by cubic
Fixes layout bugs from the 15 Oct design review across Clinical and Work, and gives On Call and Roster the shared Work summary hero card. Everything here is layout and styling only; no data, auth, or clinical content behavior changes.
Layout fixes
New summary heroes
Written for commit af15fbe. Summary will update on new commits.
Summary by CodeRabbit
New Features
Improvements
CodeAnt-AI Description
Add On Call and Roster summary cards and fix mobile layouts
What Changed
Impact
✅ All DSM comparison slots visible on phones✅ CPD log rows stay clear of the floating action bar✅ Switchboard calls available from the On Call summary💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.