Repository navigation
Therapy: list the Review sign-off queue for site administrators only - #3514
Conversation
The owner's account now carries the site administrator role, so the queue's page-list entry can be limited to administrators. The route still opens for anyone and the server still refuses sign-offs from non-administrators. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VRAKeUNKFmnQHMbMmnHWDW
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
PR Summary by QodoShow Therapy Review in the page list only to administrators
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
Merging this PR will not alter performance
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can turn these tips off under Display > Comment parts |
Qodo FixerNo findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e417201367
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CodeAnt Nitpicks1 code suggestion1. For administrators, this exposes Review in More, whose fixed hint says “Moving to their own modes”; Review is an existing Therapy page, so that explanation is false.Possible bug · |
CodeAnt PR Risk: Medium Risk
Assessed commit: |
…ors only Therapy has a results surface, so the top bar's page list never lists its pages; the header wiring had no effect and is reverted. The link on the Therapy search page is where readers actually reach Review, so that is what is now limited to administrators. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VRAKeUNKFmnQHMbMmnHWDW
|
Code review by qodo was updated up to the latest commit 05859a7 |
Code Review ✅ Approved🟡 Medium risk · Hiding the Therapy Review queue link from non-administrators could make the queue harder for them to discover; direct-route access and sign-off authorization remain unchanged. Restricts the Therapy search page's "Review queue" link and the registry navigation entry to site administrators by checking VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Approved OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
User description
Summary
isAdministratorUseron the signed-in session before rendering the link. The registry entry also getsaudience: "administrators", so every navigation consumer that filters by audience agrees. An earlier commit wired the top bar's page list too. It is reverted because Therapy has a results surface, so that list never shows Therapy's pages (Codex review).Verification
npx vitest run tests/therapy-compact-row.dom.test.tsx tests/mode-secondary-navigation.test.tsgave "Tests 66 passed (66)". This covers new administrator and reader cases for the link and for the navigation filter.npm run typecheckpassed, and eslint and prettier are clean on the changed files. Browser tests and the bundle budget are left to CI.Risk and rollout
/therapy-compass/reviewdirectly.Notes
🤖 Generated with Claude Code
https://claude.ai/code/session_01VRAKeUNKFmnQHMbMmnHWDW
CodeAnt-AI Description
Show Therapy review queue links only to site administrators
What Changed
Impact
✅ Fewer review links for non-administrator readers✅ Review queue remains easy for administrators to find✅ Direct access to the review page is unchanged💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.