Repository navigation
Work first visit: slim sign-in line, Finish setting up row, one empty-state line, no duplicate My Day tiles #3495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1a6de5f
Work first run: slim sign-in line, Finish setting up row, one empty-s…
claude a3490b1
Finish setting up row: radius tokens instead of inherit literals
claude b108725
fix: 2 findings — Keep crisis contacts above setup; Guard shift-list emp
qodo-code-review[bot] 398fce0
Revert the automated review fix b108725d3
claude 2eea4b5
On Call: keep the setup row below the emergency pin and crisis lines
claude cb2dfd0
Merge branch 'main' into claude/site-work-firstrun-xk2j9i
BigSimmo 1fe7eb8
On Call: say shift lists are unavailable, not missing, until the hand…
claude e61209d
fix(on-call): shift lists row says not set up only once the handbook …
claude 162b066
fix(on-call): a reader with no service sees not set up with the handb…
claude 01f278e
Merge remote-tracking branch 'origin/main' into claude/site-work-firs…
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| import Link from "next/link"; | ||
| import type { ReactNode } from "react"; | ||
|
|
||
| import { focusRing } from "@/components/card-recipes"; | ||
| import { cn } from "@/components/ui-primitives"; | ||
|
|
||
| /** | ||
| * The one inline empty state for a row or a short block in a work area (site | ||
| * review 12 Oct 2026, item 2): a plain sentence and, when there is somewhere | ||
| * real to go, one action. Before this a row could end at "Not set up for this | ||
| * hospital" with nothing to tap. | ||
| * | ||
| * The page-sized empty state stays `WorkEmpty` / `WorkStateNotice`; this is | ||
| * for a line inside a card. With no action it draws the sentence only, so a | ||
| * caller never invents a destination to fill the slot. | ||
| */ | ||
| export type WorkEmptyLineAction = | ||
| | { readonly label: string; readonly href: string; readonly onClick?: never; readonly testId?: string } | ||
| | { readonly label: string; readonly onClick: () => void; readonly href?: never; readonly testId?: string }; | ||
|
|
||
| export const workEmptyLineActionClass = | ||
| "inline-flex min-h-12 shrink-0 items-center rounded-sm px-1 text-sm font-semibold text-[color:var(--mode-identity)] no-underline"; | ||
|
|
||
| export function WorkEmptyLine({ | ||
| children, | ||
| action, | ||
| className, | ||
| testId, | ||
| }: { | ||
| /** The sentence: plain words that say what is missing. */ | ||
| readonly children: ReactNode; | ||
| readonly action?: WorkEmptyLineAction; | ||
| readonly className?: string; | ||
| readonly testId?: string; | ||
| }) { | ||
| return ( | ||
| <div | ||
| className={cn("flex min-w-0 flex-wrap items-center justify-between gap-x-3", className)} | ||
| data-testid={testId} | ||
| data-work-empty-line="" | ||
| > | ||
| <p className="m-0 min-w-0 flex-1 basis-40 py-1 text-sm break-words text-[color:var(--text-muted)]">{children}</p> | ||
| {action ? ( | ||
| action.href !== undefined ? ( | ||
| <Link href={action.href} data-testid={action.testId} className={cn(workEmptyLineActionClass, focusRing)}> | ||
| {action.label} | ||
| </Link> | ||
| ) : ( | ||
| <button | ||
| type="button" | ||
| onClick={action.onClick} | ||
| data-testid={action.testId} | ||
| className={cn(workEmptyLineActionClass, focusRing)} | ||
| > | ||
| {action.label} | ||
| </button> | ||
| ) | ||
| ) : null} | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.