Repository navigation
fix(ui): stabilize assessment scrolling and sticky work tabs - #3457
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
Merging this PR will not alter performance
|
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
PR Summary by QodoStabilize assessment scrolling and shared sticky work tabs
AI Description
Diagram
High-Level Assessment
Files changed (6)
|
Code Review by Qodo
1. PR UI shard validation fails
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
CodeAnt PR Risk: Medium Risk
Assessed commit: |
…shards for assessment spec
Code Review ✅ Approved🟡 Medium risk · The shared sticky-tab and installed-layout focus-clearance changes could misposition work tabs or leave focused controls obscured across work pages. Stabilizes scrolling on
Review coverage🤖 Auto-approval Approved 📋 Rules No rules evaluated 🧪 Functional validation Not enabled · Set up OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
Code review by qodo was updated up to the latest commit 34866cf |
User description
Summary
Repair scrolling on
/teaching/assessmentsand its shared work tabs. Header visibility, resize and scroll events now share an animation-frame update; unchanged geometry is not republished, and animation completion replaces repeated layout polling while stationary. Apply bottom-action focus clearance to both document scrolling and the installed layout's main scroll surface.Add assessment regression coverage for direction reversals, tab and role changes, sheets, bottom reachability, keyboard focus, rotation, six viewport widths, enlarged text, reduced motion and forced colours. Register the new spec with the phone-chrome selector and document the shared behavior.
Areas touched: App experience, Engineering platform.
Verification
Earlier local evidence was obtained in the original development checkout at
adcc101ab2d469fa350be15c274b44461e253915with the repair applied. This PR isolates the six-file repair on current main; those results are not fresh verification of this PR commit.verify:phone-chromeexited 1 because a document-viewer actions-dialog setup timed out. That exact case passed on a focused rerun without edits; five other ownership cases passed initially.verify:uifailed on the Smart-search accessibility test's 60-second total timeout (tests/ui-clinical-ask.spec.ts:210) and was interrupted after test 99. Remaining broad coverage is unrun; the timeout is not proven pre-existing.Verification not run: format, lint, typecheck, unit tests, builds, browser tests, provider-backed checks and hosted CI observation were not rerun for this bare publication request. No checks were rerun solely to publish the prepared change.
UI verification not run: this publication request does not rerun the wider UI gate. Earlier incomplete and failed UI evidence is described above.
Risk and rollout
Notes
The original development checkout and its unrelated audit work are preserved. This PR contains only the scrolling repair's six files.
Summary by cubic
Stabilizes scrolling on
/teaching/assessmentsso sticky work tabs no longer flicker, stick incorrectly, or fight the bottom action dock, including on installed-layout phones.Behavior changes
#main-content, giving installed phones the same clearance as browser tabs.Coverage
ui-roster-team.spec.tsmoves to shard 3 to keep duration balance, and estimated timings are added to the release manifest.Written for commit 34866cf. Summary will update on new commits.
CodeAnt-AI Description
Keep assessment tabs aligned as the header moves and focused controls clear of the action dock
What Changed
Impact
✅ Fewer assessment scroll jumps✅ Tabs stay aligned as the header moves✅ Focused controls stay above the installed-phone action dock💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.