Repository navigation
Remove on-screen example-data notices, tidy spacing, match Work header pill to Clinical - #3450
Conversation
The owner asked that nothing on screen calls the data example or made-up. The example data switch, export block and blocked-action sheet stay, and example data is turned off and signed in to from Settings. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013DB4o6bJhwnnpqTcrVdcC4
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013DB4o6bJhwnnpqTcrVdcC4
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
Merging this PR will improve performance by ×2.7
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ ℹ️ | medication-entities: medicationEntityMatchesInText |
11.5 ms | 4.2 ms | ×2.7 |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/remove-example-notice-spacing-bp4x20 (3ed546c) with main (1550a6b)
…ton and phone list padding The Work area pill now matches the clinical pill: 13rem wide (narrower only where the bell and AI Search leave less room), 48px tall glass, chevron at the right end. The round glass buttons are 48px like the clinical ones. The Roster outline buttons use semibold text with a little vertical padding, and On Call phone rows keep the same gutter on the right as on the left. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013DB4o6bJhwnnpqTcrVdcC4
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013DB4o6bJhwnnpqTcrVdcC4
|
CodSpeed Performance Analysis reports a regression in Generated by Claude Code |
Both the work and clinical area pills drop the 13rem minimum width, so a short name like Roster sits right beside its chevron. Height stays 48px on both. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013DB4o6bJhwnnpqTcrVdcC4
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
BigSimmo has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
codeant-ai
Bot
added
the
size:L
PR Summary by QodoRemove example-data notices and align Work header spacing
AI Description
Diagram
High-Level Assessment
Files changed (51)
|
Understood. The rationale is clear:
These findings remain active until explicitly dismissed. Findings 4 and 5 were not addressed by this response. |
Qodo Fixer✅ Committed (5) · ☑ Fixed (5) Commits pushed directly to this PR — no separate fix PR opened. Process — 5 fixed
|
|
Code review by qodo was updated up to the latest commit 7449d9e |
Restores minmax(0, max-content) for the name column so a name that fits is never cut short by sub-pixel rounding (review finding). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013DB4o6bJhwnnpqTcrVdcC4
…cing-bp4x20' into claude/remove-example-notice-spacing-bp4x20 # Conflicts: # src/app/work-mode.css
The Qodo bot pushed three changes that reversed what the owner asked for and turned CI red: the Clinical pill regained its 13rem floor (the owner asked for no empty space), Open shifts regained an Example label (the owner asked for every example notice to go, and the sample test fails on it), and AI Search dropped example records, which leaves CPD answers on a loading card that never ends. This puts back the reviewed versions of those three files. The bot's comment tidy-ups stay. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013DB4o6bJhwnnpqTcrVdcC4
|
The Qodo Fixer commits turned CI red and reversed the owner's requests, so the latest push puts back the reviewed versions of three files:
The comment tidy-ups and the max-content name track stay. Focused tests: 7 files, 102 tests passed. Generated by Claude Code |
|
Code review by qodo was updated up to the latest commit 6cea00d |
…held PR 3412 held all five cultural records, so the Cultural domain filter is no longer offered and the phone journey counts 11 domain buttons, not 12. Main's push CI does not run this browser shard, so the stale count first showed up on this PR. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013DB4o6bJhwnnpqTcrVdcC4
|
Generated by Claude Code |
|
Code review by qodo was updated up to the latest commit 8ed3a76 |
…-notice-spacing-bp4x20 # Conflicts: # tests/ui-formulation.spec.ts
|
No code changes since the last review — review skipped |
Code Review ✅ Approved 2 closed / 2 findings🟡 Medium risk · Removing example-data labels across roster, pay, teaching, and admin screens could lead users to mistake synthetic records for their own. Removes on-screen example-data notices, tidies spacing, and matches the Work header area pill to the Clinical pill. Search now excludes example records from roster, teaching, CPD, and On Call results. Resolved: the pill width no longer truncates long area names on 320–375px phones, and suppressed example areas no longer leave search answers stuck or falsely empty. No open issues found.
✅ 2 closed✅ Edge Case: Fixed pill width truncates long area names on 320–375px phones
✅ Bug: Suppressed example areas leave search answers stuck or falsely empty
Review coverage🤖 Auto-approval Approved 📋 Rules No rules evaluated 🧪 Functional validation Not enabled · Set up OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
I'm re-running the failed jobs once. If it stalls again, I'll treat it as real and dig in. Generated by Claude Code |
…rowser groups, stop a frozen unit batch sooner (#3451) * Cut CI wait: split the tablet and Safari release legs, rebalance PR browser groups, stop a frozen unit batch sooner Main pushes took 36-40 minutes because Railway's "Wait for CI" holds the deploy until every job ends, and the tablet leg ran the whole tablet suite on one runner. It hit the 30-minute global timeout on main run 38053471704 with 345 tablet tests never run. Tablet now splits four ways from a timing table measured off that leg's log (unreached files use the mobile-webkit cost, marked as estimates), and desktop Safari splits three ways from its existing table. Production UI shard 3 ran 521s of tests against 401s and 346s on PR run 38101082169, so it set every PR's wall clock. The profiles are re-measured from that run and four files move, giving 422/426/420s. A unit coverage partition froze on PR #3450 and held the run to the 20-minute job cap. The test step now stops at 13 minutes (partitions take 5-9). Every test still runs, on one worker, with zero retries and the same per-test timeouts. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JoxhPS6iT7SYdBZeSR1w1S * Pin the committed webkit (3) and tablet (4) leg counts in the release balance test Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JoxhPS6iT7SYdBZeSR1w1S --------- Co-authored-by: Claude <noreply@anthropic.com>
User description
Requested by Josh · project thread
Summary
Before: while example data showed, every work area carried an "EXAMPLE · Made-up data to look around. Nothing is saved. Sign in / Turn off" strip under the header, plus amber Example tags, "Example data. Changes stay on this page" notes, "Example only. Sign in to add your own shifts" notices and "Example ·" prefixes on rows. The Work header's area pill was shorter than the Clinical "Answer" pill, with empty space before its chevron, and its round buttons were 44px glass against Clinical's 48px.
After: none of those notices draw. The example data switch, the export/share/copy block and its explaining sheet all stay, and example data is turned off, and signed in to, from Settings. The Work and Clinical area pills are both 48px tall and both hug their name, with the chevron right after it and no empty space (Josh, 10 Oct 2026), up to a width limit. Round glass buttons are 48px. Roster's outline buttons (Who is on, Phone numbers and the rest) use semibold text with a little vertical padding, and On Call phone rows keep a 16px right gutter instead of 8px.
Kept on purpose: notices that explain why a tapped action did nothing, On Call's fake phone numbers and "these crisis lines are real" line (safety), the safety plan's non-working numbers, First Nations governance labels, the printed CPD summary's "not a personal CPD record" line, "Roster is showing example shifts only, so your shifts aren't shown" (explains hidden real data), and the always-example Assessments and Workforce prototypes.
Areas touched: Personal practice, App experience, Design system, Prototypes
Verification
npm run test:focusedover the notice changes: 144 files, 1899 tests passed. Over the CSS and button changes: 18 files, 303 tests passed. Over the final pill change: 4 files, 61 tests passed.tsc --noEmitclean, eslint clean on changed files.Risk and rollout
Notes
🤖 Generated with Claude Code
https://claude.ai/code/session_013DB4o6bJhwnnpqTcrVdcC4
Summary by Gitar
This will update automatically on new commits.