Skip to content

test(specifiers): scope the Top match badge to its visible owner #3193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigSimmo merged 6 commits into from
Oct 1, 2026
Merged

test(specifiers): scope the Top match badge to its visible owner #3193

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ad1717d
test(specifiers): scope the Top match badge to its visible owner
BigSimmo Sep 30, 2026
981ed3b
fix(specifiers): restore three lines dropped in transcription
BigSimmo Sep 30, 2026
2bd33c7
fix(specifiers): restore the Breadcrumb assertion in the map-flow test
BigSimmo Sep 30, 2026
b5e28c3
fix(specifiers): restore the builder Search-tab assertions
BigSimmo Sep 30, 2026
eb129b6
Merge branch 'main' into fix/specifiers-top-match-strict-mode-violation
BigSimmo Oct 1, 2026
25fdee6
Merge branch 'main' into fix/specifiers-top-match-strict-mode-violation
BigSimmo Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions tests/ui-specifiers.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import AxeBuilder from "@axe-core/playwright";
import { expect, test, type Locator, type Page, type TestInfo } from "playwright/test";
import { clickWhenSettled, expectSingleSettledOwner } from "./playwright-settlement";
import { clickWhenSettled, expectSingleSettledOwner, visibleByText } from "./playwright-settlement";

const axeWcagTags = ["wcag2a", "wcag2aa", "wcag21a", "wcag21aa"];
const axeBlockingImpacts = new Set(["critical", "serious"]);
Expand Down Expand Up @@ -141,7 +141,12 @@ test("searches clinical language without provenance fields and carries a result
await page.goto(guidesUrl.toString());
}
await expect(page).toHaveURL(/scope=guides/);
await expect(page.getByText("Top match", { exact: true })).toBeVisible();
// `visibleByText`, not a bare getByText: until React's `$RV` reveal runs, the
// streamed copy of this route is still parked in a `<div hidden id="S:n">` at
// the end of <body> (see `(search-app)/loading.tsx`), so a page-level query
// resolves to the live badge plus that hidden twin and trips strict mode.
// Chromium reveals before this line; WebKit loses the race (#093).
await expect(visibleByText(page, "Top match", { exact: true })).toBeVisible();
// Below the sm breakpoint the results band swaps the desktop trigger for its phone twin.
const phoneWidth = (page.viewportSize()?.width ?? 1280) < 640;
const filterTrigger = page.getByTestId(
Expand Down
Loading