Repository navigation
Land #94 (core set) and #101 (review follow-ups) on main - #103
Merged
Merged
Conversation
…irst CORE_CARD_IDS in data.ts. Library shows a Start here badge and a 'Start here first' sort. New drills get order: core-first; saved drills without the field keep id order, so a stored cardIndex still means the same card.
…o grok/review-followups-1027
…o grok/land-94-101-1027
…aria-label removal
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 20 minutes. View limit details
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#94 and #101 were merged into their stacked branches (grok/new-cards-1027, grok/review-connection-1027) after #93 and #97 had already landed, so their changes never reached main. This branch is current main with both merged in.
Edits: (1) library.tsx aria-label conflict with #92 resolved by keeping #92's deletion; the visible 'Start here' badge is unchanged. (2) drill-page.test.tsx updated to use the core-set order (CORE_FIRST_CARD_IDS[0]) because new drills now start on the core set; no checks loosened.
Landing on Josh's instruction in chat (Oct 27, 6:10 PM AWST: merge all the PRs). Merge commit only.
Summary by Gitar
CORE_CARD_IDSandCORE_FIRST_CARD_IDSso new drills start on the "Start here" setorderfield keep id order viadrillCardIdThis will update automatically on new commits.