[codex] fix Prompt Optimize ProseMirror writer - #72
Open
weiadou wants to merge 3 commits into
Open
Conversation
weiadou
force-pushed
the
codex/fix-prompt-optimize-prosemirror-write
branch
from
August 3, 2026 01:56
23ef9e7 to
7af42af
Compare
weiadou
marked this pull request as ready for review
August 3, 2026 02:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selectAllreportsfalseRoot cause
The contenteditable writer treated
selectAllandinsertTextas one combined success condition. In the current Codex Desktop ProseMirror composer, the selection can already be established andinsertTextis supported, whileselectAllreportsfalse. That prevented the insert and incorrectly fell back to the clipboard.Validation
node --check scripts/prompt-optimize.jsnode --check tests/prompt-optimize-prosemirror-writer.test.jsnode --test tests/prompt-optimize-prosemirror-writer.test.js(2 passed)index.json, verified its Prompt Optimize entry is unique, and verified its SHA-256 matchesscripts/prompt-optimize.jsgit diff --check origin/main...HEADinsertTextis supported and enabledNo API key or model configuration was read or changed, and validation made no external model request.
Related
Fixes #71
Related to #55 and #59. Builds on #56: this PR intentionally includes the transport fallback proposed there because upstream
mainstill serves Prompt Optimize 1.0.0; the writer fix applies on top of that fallback.