fix: skip chest particles that require typed data instead of crashing#516
Merged
tastybento merged 1 commit intodevelopfrom May 3, 2026
Merged
fix: skip chest particles that require typed data instead of crashing#516tastybento merged 1 commit intodevelopfrom
tastybento merged 1 commit intodevelopfrom
Conversation
Particle.DUST is the only particle type for which we can construct the required DustOptions data. Previously, any other particle type fell to particleData = null, and spawnParticle would throw IllegalArgumentException when the configured particle required non-void data (e.g. ITEM, BLOCK, ENTITY_EFFECT). Detect particles with non-void getDataType(), log a warning naming the configured particle, and return early instead of spawning. DUST and particles with Void data still work as before. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chestParticle()previously only constructed particle data forParticle.DUST. For every other particle type,particleDatastayednull, andWorld#spawnParticlewould throwIllegalArgumentExceptionif the configured particle required non-void data (e.g.ITEM,BLOCK,ENTITY_EFFECT).getDataType()is non-Void, log a warning naming the configured particle, and return early instead of spawning.DUSTand particles whose data type isVoidcontinue to work unchanged.Test plan
ITEM) and confirm a warning is logged instead of an exception.DUSTand confirm the existing rarity-colored dust still spawns.FLAME) and confirm it still spawns.🤖 Generated with Claude Code