fix: resync magic block to client after entity-spawn cancel#514
Merged
tastybento merged 1 commit intodevelopfrom May 3, 2026
Merged
fix: resync magic block to client after entity-spawn cancel#514tastybento merged 1 commit intodevelopfrom
tastybento merged 1 commit intodevelopfrom
Conversation
When a magic-block roll produces a mob, handleEntitySpawn cancels the triggering BlockBreakEvent at EventPriority.HIGHEST. The client has already played the "block disappearing" animation by then and predicted the block as gone, but never receives a corrective block-update packet, so the magic block appears transparent until the chunk resyncs (e.g. on relog). Send a block change to the mining player immediately after the cancel so the client repaints the actual server-side block state. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleEntitySpawncancels the triggeringBlockBreakEventatEventPriority.HIGHEST. By that point the client has already played the "block disappearing" animation and predicted the block as gone, but the server never sends a corrective block-update packet.Player#sendBlockChange.Test plan
EntitySpawnEvent-triggered) and for null-player paths (minion breaks).🤖 Generated with Claude Code