Guard against NPE in loadData() when called before onEnable()#509
Merged
tastybento merged 2 commits intodevelopfrom Apr 26, 2026
Merged
Guard against NPE in loadData() when called before onEnable()#509tastybento merged 2 commits intodevelopfrom
tastybento merged 2 commits intodevelopfrom
Conversation
Agent-Logs-Url: https://github.com/BentoBoxWorld/AOneBlock/sessions/c08cff2f-189f-4aa3-8ae9-7e605aa1bcf3 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix AOneBlock error on server reload
Guard against NPE in loadData() when called before onEnable()
Apr 26, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



CraftEngine (and Nexo/ItemsAdder) fire their reload events during server startup before
AOneBlock.onEnable()has run, meaningoneBlockManageris stillnullwhenloadData()is invoked via the event listener — causing aNullPointerException.Changes
AOneBlock.loadData()— added an early-return null guard foroneBlockManager. When the manager hasn't been initialized yet,loadData()is a no-op; phases load normally duringonEnable().AOneBlockTest— addedtestLoadDataWhenManagerIsNullto assert that callingloadData()beforeonEnable()returnsfalsewithout throwing.