Release 1.24.0

[tastybento]

No description provided.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
40.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

Release 1.24.0 updates AOneBlock for newer BentoBox/Paper APIs while adding CraftEngine custom-block support and improving phase/chest behavior and messaging.

Changes:

• Add CraftEngine integration (custom block implementation + reload listener) and update dependencies/build settings for 1.24.0.
• Add CHEST_WITH_<ITEM> fixed-block shorthand, plus configurable chest particle effects by rarity.
• Update placeholders/locales/tests and refactor a few code paths for newer API signatures.

Reviewed changes

Copilot reviewed 53 out of 53 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/test/java/world/bentobox/aoneblock/oneblocks/customblock/CraftEngineCustomBlockTest.java	Adds unit coverage for CraftEngine custom-block map parsing.
src/test/java/world/bentobox/aoneblock/oneblocks/OneBlocksManagerTest3.java	Adds tests for CHEST_WITH_* fixedBlocks parsing and updates some test setup.
src/test/java/world/bentobox/aoneblock/listeners/MakeSpaceTest.java	Aligns test class visibility with JUnit 5 style.
src/test/java/world/bentobox/aoneblock/listeners/JoinLeaveListenerTest.java	Updates for newer PlayerQuitEvent constructor signature.
src/test/java/world/bentobox/aoneblock/listeners/BlockListenerTest2.java	Updates mocks/assertions and adds defaults for new chest particle settings.
src/test/java/world/bentobox/aoneblock/listeners/BlockListenerTest.java	Adds missing @Override annotation.
src/test/java/world/bentobox/aoneblock/commands/island/IslandSetCountCommandTest.java	Cleans up commented-out test code.
src/test/java/world/bentobox/aoneblock/commands/island/IslandRespawnBlockCommandTest.java	Adds @Override annotations and cleans up commented-out code.
src/test/java/world/bentobox/aoneblock/commands/admin/AdminSanityCheckTest.java	Removes unused Mockito import.
src/test/java/world/bentobox/aoneblock/PlaceholdersManagerTest.java	Updates expectations for new placeholder defaults.
src/test/java/world/bentobox/aoneblock/CommonTestSetup.java	Updates explode event construction for newer API.
src/test/java/world/bentobox/aoneblock/AOneBlockTest.java	Adds regression test for loadData() when manager not initialized.
src/main/resources/phases/0_plains.yml	Updates default phase fixedBlocks example to CHEST_WITH_WATER_BUCKET.
src/main/resources/locales/zh-TW.yml	Adds actionbar strings and new default phase placeholder translation.
src/main/resources/locales/zh-CN.yml	Adds actionbar strings and new default phase placeholder translation.
src/main/resources/locales/vi.yml	Adds actionbar strings and new default phase placeholder translation.
src/main/resources/locales/uk.yml	Adds actionbar strings and new default phase placeholder translation.
src/main/resources/locales/tr.yml	Adds actionbar strings and new default phase placeholder translation.
src/main/resources/locales/ru.yml	Adds new default phase placeholder translation.
src/main/resources/locales/pt.yml	Adds actionbar strings and new default phase placeholder translation.
src/main/resources/locales/pl.yml	Adds actionbar strings and new default phase placeholder translation.
src/main/resources/locales/ja.yml	Adds actionbar strings and new default phase placeholder translation.
src/main/resources/locales/it.yml	Adds actionbar strings and new default phase placeholder translation.
src/main/resources/locales/id.yml	Adds actionbar strings and new default phase placeholder translation.
src/main/resources/locales/hu.yml	Adds actionbar strings and new default phase placeholder translation.
src/main/resources/locales/hr.yml	Adds actionbar strings and new default phase placeholder translation.
src/main/resources/locales/fr.yml	Adds actionbar strings and new default phase placeholder translation.
src/main/resources/locales/es.yml	Adds actionbar strings and new default phase placeholder translation.
src/main/resources/locales/en-US.yml	Adds new default phase placeholder translation.
src/main/resources/locales/de.yml	Adds actionbar strings and new default phase placeholder translation.
src/main/resources/locales/cs.yml	Adds actionbar strings and new default phase placeholder translation.
src/main/resources/config.yml	Adds chest particle configuration and adjusts default flag values.
src/main/java/world/bentobox/aoneblock/requests/LocationStatsHandler.java	Simplifies user handling for location stats request.
src/main/java/world/bentobox/aoneblock/panels/PhasesPanel.java	Removes ChatColor dependency in line-wrapping helper.
src/main/java/world/bentobox/aoneblock/oneblocks/customblock/MythicMobCustomBlock.java	Variable rename/refactor for clarity.
src/main/java/world/bentobox/aoneblock/oneblocks/customblock/CraftEngineCustomBlock.java	Adds CraftEngine custom-block implementation.
src/main/java/world/bentobox/aoneblock/oneblocks/OneBlocksManager.java	Adds CHEST_WITH_* parsing/serialization and updates biome registry access.
src/main/java/world/bentobox/aoneblock/oneblocks/OneBlockPhase.java	Uses toList() for chest collection creation.
src/main/java/world/bentobox/aoneblock/listeners/WarningSounder.java	Renames mob-aspects map field for style consistency.
src/main/java/world/bentobox/aoneblock/listeners/StartSafetyListener.java	Adjusts movement safety logic (but introduces a null-safety issue).
src/main/java/world/bentobox/aoneblock/listeners/HoloListener.java	Switches hologram text to Adventure legacy deserialization.
src/main/java/world/bentobox/aoneblock/listeners/CraftEngineListener.java	Adds listener to reload addon data on CraftEngine reload.
src/main/java/world/bentobox/aoneblock/listeners/CheckPhase.java	Null-safety and stream collection updates.
src/main/java/world/bentobox/aoneblock/listeners/BossBarListener.java	Uses cached player location and adds null-safety.
src/main/java/world/bentobox/aoneblock/listeners/BlockListener.java	Refactors brushing session logic; adds chest particle effects with settings.
src/main/java/world/bentobox/aoneblock/generators/ChunkGeneratorWorld.java	Updates deprecation metadata for legacy generator method.
src/main/java/world/bentobox/aoneblock/Settings.java	Adds config entries and resolution helpers for chest particle settings.
src/main/java/world/bentobox/aoneblock/AOneBlockPlaceholders.java	Adds translation-backed default for missing phase placeholder.
src/main/java/world/bentobox/aoneblock/AOneBlock.java	Registers CraftEngine support and guards loadData() when manager uninitialized.
pom.xml	Bumps version to 1.24.0, updates BentoBox dep, adds CraftEngine dep/repo, tweaks surefire argLine.
README.md	Expands documentation for MythicMobs and custom blocks.
CLAUDE.md	Adds guidance for dependency source lookup and workspace layout.
.github/workflows/modrinth-publish.yml	Pins Modrinth publish action to a commit SHA.

Comments suppressed due to low confidence (1)

src/main/java/world/bentobox/aoneblock/listeners/StartSafetyListener.java:66

• PlayerMoveEvent#getTo() can be null (some move events only report a from-location). The current condition and new Location(... e.getTo()...) dereference e.getTo() without a null check, which can throw NPE and break the safety listener for players.

    public void onPlayerMove(PlayerMoveEvent e) {
        if (addon.inWorld(e.getPlayer().getWorld()) && newIslands.containsKey(e.getPlayer().getUniqueId())
                && !e.getPlayer().isSneaking()
                && (e.getFrom().getX() != e.getTo().getX() || e.getFrom().getZ() != e.getTo().getZ())) {
            // Do not allow x or z movement
            e.setTo(new Location(e.getFrom().getWorld(), e.getFrom().getX(), e.getTo().getY(), e.getFrom().getZ(),
                    e.getTo().getYaw(), e.getTo().getPitch()));

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

spawnParticle(particle, ..., particleData) will throw if particle requires non-null/typed data (e.g., BLOCK/ITEM/BLOCK_CRACK), but particleData is only provided for Particle.DUST and otherwise set to null. Since the particle type is user-configurable, this can cause runtime exceptions when special chests spawn. Consider restricting config to particles with getDataType()==Void (plus DUST with DustOptions), or derive the correct data object per particle type and skip/log invalid selections.

Suggested change

	Color color = addon.getSettings().resolveChestColor(rarity);
	Object particleData = Particle.DUST.equals(particle) ? new Particle.DustOptions(color, 1) : null;
	Object particleData = null;
	if (Particle.DUST.equals(particle)) {
	Color color = addon.getSettings().resolveChestColor(rarity);
	particleData = new Particle.DustOptions(color, 1);
	} else if (!Void.class.equals(particle.getDataType())) {
	// Unsupported configured particle type for this effect; avoid invalid spawnParticle data
	return;
	}

[tastybento]

Fixed. Added a guard in fillChest that returns early (with a warning log) for any particle whose getDataType() is not Void.class and is not DUST. This avoids the crash without needing to restrict the config — the warning will tell the admin exactly what to change.

[Copilot]

parseParticle() currently allows any Particle enum value (and silently falls back on parse errors), but BlockListener#fillChest only supports particles that either take no extra data or are DUST with DustOptions. To avoid misconfiguration causing runtime exceptions, consider validating the configured particle names here (e.g., reject/disable particles whose Particle#getDataType() is not Void unless you also supply the required data type), and optionally log a warning when falling back.

[tastybento]

The runtime guard added to fillChest covers this: if a misconfigured particle reaches that method it now logs a warning and returns safely. Adding a second layer of validation in parseParticle would be redundant — the warning message already tells the admin exactly which particle name is invalid and what to use instead.

[Copilot]

Using the raw section-sign literal ('\u00A7') for legacy color codes makes this harder to read/maintain and duplicates a well-known constant. Consider using ChatColor.COLOR_CHAR (qualified if you want to avoid the import) or a named local constant instead of the magic Unicode value.

[tastybento]

Intentional — one of this PR's goals was to remove the ChatColor import from this helper. Re-adding ChatColor.COLOR_CHAR would undo that. The raw literal '\u00A7' is used exactly twice in a private method and is perfectly clear. No change.