Moving module tests from test_assignments to test_modules#8
Open
AsherGlick wants to merge 1 commit intoBelfrySCAD:mainfrom
Open
Moving module tests from test_assignments to test_modules#8AsherGlick wants to merge 1 commit intoBelfrySCAD:mainfrom
AsherGlick wants to merge 1 commit intoBelfrySCAD:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed two module-like tests in
test_assignments.py.TestParameterLists.test_empty_parametersis the same test asTestModuleDefinition.test_module_no_parametersso I removed it.TestParametersList.test_parameters_trailing_commawas moved and renamed toTestModuleDefinition.test_module_multiple_parameters_trailing_commato fit with the naming scheme ofTestModuleDefinition