Singlestatement Comments#7
Open
AsherGlick wants to merge 2 commits intoBelfrySCAD:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running into an issue where putting a comment after a single statement, a statement without brackets, would cause the parser to fail to parse. For example:
However the comment worked just fine when braces were used to turn it into a code block
This PR has 2 commits, the first one creates a number of new tests surrounding comments, including one larger test that dynamically inserts comments into various places in a specific piece of openscad code to test how parsing works in different locations.
The second commit attempts to address the problem mentioned above by allowing comments to be parsed after a modular call before the child statement.
This testing also identified several other places where comments do not parse correctly in, however I did not dig deeper into those cases and excluded them from the tests instead. This way whomever picks up the mantle of fixing the issues, myself or someone else, will have pre-written test cases for them to use.
I also included a simple optional validation of the arpeggio parse tree so that we can be more confident in the differences between
parserandparser_comments.