Repository navigation
Conversation
Although the extension worked against Behat 3.x and 4.x when it was built, it now causes errors when run with 4.x. Embarrassingly, I didn't notice my IDE had imported a `use` statement for Behat's own PHPUnitExceptionStringer class. At the time, that class was still present in the 4.x series, but now that the PR removing it has been merged the extension obviously fails to load. Our own version of PHPUnitExceptionStringer was never used, meaning we also didn't catch that the API signature is incompatible with Behat 3.x due to the presence of strict parameter types. That's also now fixed.
Now that Behat 4 has no built-in support for stringifying PHPUnit, we don't need the hack to disable the built-in support when testing. However, the output in Behat 3.x without this extension is different, and coupled to the implementation of Behat 3.x built-in stringer. Since that is already covered by Behat's own features, I think it is both unnecessary and brittle to test it here (and confusing, since the output with and without this extension would currently be very similar). Therefore, I have instead refactored the suite and Behat profiles so that we only test the behaviour without this extension installed when running Behat 4.x.
Unlikely to include anything else in 1.1.0 - prepare the CHANGELOG now so it's ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although the extension worked against Behat 3.x and 4.x when it was built, it now causes errors when run with 4.x.
Embarrassingly, I didn't notice my IDE had imported a
usestatement for Behat's own PHPUnitExceptionStringer class. At the time, that class was still present in the 4.x series, but now that the PR removing it has been merged the extension obviously fails to load.Our own version of PHPUnitExceptionStringer was never used, meaning we also didn't catch that the API signature is incompatible with Behat 3.x due to the presence of strict parameter types. That's also now fixed.
Finally (and as originally planned), removes the temporary hack for testing without the built-in functionality enabled (since this fails now that Behat 4.0 does not have any built-in functionality).
Fixes #11