msi-ec: add Cyborg 15 B2RW and MS-1606 backlight support - #779
Conversation
|
AI? |
|
Where you got Mystic Light code? You should remove it, because it's not related to project. Keep only EC version you want to add |
|
Well, on my laptop trying to control the backlight via current msi-ec method fails miserably. So I thought maybe a fix is needed specifically for my type of laptops? With this fix Linux correctly recognizes the 5 stage backlight and I can control it. Without it neither Linux, nor MControlPanel is capable to control the backlight. |
|
G2_1 is wrong config, right one is G2_5 I'll wipe your code and fix to correct config. You should use https://openrgb.org/ for your RGB keyboard. I have no idea if your model is supported |
This reverts commit 571d6f1.
|
what is MS-1606? |
There are 3 models: RGB: https://www.msi.com/Laptop/Cyborg-15-B13WX https://www.msi.com/Laptop/Cyborg-15-B2RWX White keyboard: https://www.msi.com/Business-Productivity/VenturePro-15-A2RWX Cyborgs have same EC revision, but VenturePro probably have different - no data to prove. In this case - single color controller is enabled in EC and banned in whitelist.
e54afae to
65211e3
Compare
|
Yea, I got it from the USB ID that controls the lighting: 0db0:1606 |
|
Where you got code for backlight control? If it's yours - you can release it as new project, but it can't be bundled with |
|
Added, thank you |
|
I checked multiple projects, including the windows version of MSI Control center. After determining where it controls the backlight, wrote the code to change the backlight and with the help of AI to fix any problems it sees in the code (as it's been a long time since I touched c). |
|
Okay, good luck with PRing the OpenRGB. In my opinion keyboard RGB controller which connected via USB shouldn't be a kernel module, but userspace app/service. And OpenRGB seems to be good balance. For some reason, MSI choose such weird way of control, in comparison to other, where is worth to use kernel modules |
close #647
close #726
close #762
Note:
There are 3 models:
RGB:
https://www.msi.com/Laptop/Cyborg-15-B13WX
https://www.msi.com/Laptop/Cyborg-15-B2RWX
White keyboard:
https://www.msi.com/Business-Productivity/VenturePro-15-A2RWX
They probably have different EC revision. In this case - single color controller is enabled in EC and banned in whitelist.
What changed
15Q3EMS1.108firmware support for Cyborg 15 B2RWEKG/B2RWGKG0db0:1606MSI MysticLight MS-1606 controllermsi::kbd_backlightwith levels 0 through 4Why
On this generation, EC register
0xd3is only a status mirror. Writes updatethe register but do not change the physical keyboard. The keyboard lighting is
controlled by a dedicated USB HID device.
The MS-1606 does not provide a separate brightness command or useful RGB
readback. The driver therefore scales a configurable fixed RGB color in the
steady-effect packet. The default
255:50:0color can be changed with thecolor_red,color_green, andcolor_bluemodule parameters.Validation
7.1.5-1-cachyoswith Clangcheckpatch.pl --strict: zero errors, warnings, or checks