Skip to content

Adding more network features for scripts. #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Toys0125 wants to merge 8 commits into
base: developer
Choose a base branch
from
+19 −0
Open

Adding more network features for scripts. #709

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7c02d4b
Adds NetworkTime, and NetworkDeltaTime.
Toys0125 Apr 2, 2026
d170548
Adds if there is an owner check.
Toys0125 Apr 2, 2026
f778cd1
Merge remote-tracking branch 'origin/developer' into Expose-Network-Time
Toys0125 Apr 3, 2026
c6ef617
Add TryGetOwnerId.
Toys0125 Apr 3, 2026
484a1d6
Add more exposeable systems to cilbox.
Toys0125 Apr 3, 2026
6c6f8b9
Merge branch 'Expose-Network-Time' of https://github.com/Toys0125/Bas…
Toys0125 May 3, 2026
5c757e9
Move the time to NetworkBehaviour.
Toys0125 May 3, 2026
8c21eab
Have it auto request the server and have it cached for next time.
Toys0125 May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions Basis/Packages/com.basis.framework/Networking/BasisNetworkBehaviour/BasisNetworkBehaviour.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ public ushort NetworkID
public ushort CurrentOwnerId;
public BasisNetworkPlayer currentOwnedPlayer;

public DateTime RemoteUtcTime => BasisNetworkManagement.RemoteUtcTime();
public long RemoteDeltaTime => BasisNetworkManagement.RemoteTimeDelta();
/// <summary>
/// the reason its start instead of awake is to make sure progation occurs to everything no matter the net connect
/// </summary>
Expand Down Expand Up @@ -122,6 +124,8 @@ private void LowLevelOwnershipReleased(string uniqueEntityID)
{
if (uniqueEntityID == clientIdentifier)
{
IsOwnedLocallyOnServer = false;
IsOwnedLocallyOnClient = false;
OnServerOwnershipDestroyed();
}
}
Expand All @@ -142,6 +146,7 @@ private void LowLevelOwnershipTransfer(string uniqueEntityID, ushort NetIdNewOwn
BasisUnInitalizedPlayer UnInitalizedPlayer = new BasisUnInitalizedPlayer(CurrentOwnerId);
BasisDebug.LogError($"No Owner for Id {CurrentOwnerId} Creating Fake {nameof(BasisUnInitalizedPlayer)} this should only occur rarely");
UnInitalizedPlayer.Initialize();
currentOwnedPlayer = UnInitalizedPlayer;
OnOwnershipTransfer(UnInitalizedPlayer);
}
}
Expand Down Expand Up @@ -302,6 +307,20 @@ public async Task<BasisOwnershipResult> RequestWhoIsOwnershipAsync(int Timout =
BasisOwnershipResult Result = await BasisNetworkOwnership.RequestCurrentOwnershipAsync(clientIdentifier, Timout);
return Result;
}

public bool TryGetOwnerId(out ushort OwnerId)
Copy link
Copy Markdown
Collaborator

@dooly123 dooly123 Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i need convincing this is better then just making people async the server and store the result

Copy link
Copy Markdown
Contributor Author

@Toys0125 Toys0125 May 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its just a wrapper for the normal check you may do in normal C#, and this allows direct access for Cilbox scripts to ask for the OwnerId directly, reducing the amount of instructions needing to call.

{
if (currentOwnedPlayer != null && currentOwnedPlayer.IsOwnerCached(clientIdentifier))
{
OwnerId = currentOwnedPlayer.playerId;
return true;
}
OwnerId = 0;
// if we dont have it cached locally we can ask the server to give it to us to cache and invoke any ownershipTransfer events.
RequestWhoIsOwnershipAsync();
return false;
}

public virtual void OnNetworkReady()
{

Expand Down
Loading