Skip to content

Improve test coverage for continuous-time hierarchical models + Discretizer #237

Merged
DanWaxman merged 4 commits into
mainfrom
ml-hierarchical-tests
May 28, 2026
Merged

Improve test coverage for continuous-time hierarchical models + Discretizer #237
DanWaxman merged 4 commits into
mainfrom
ml-hierarchical-tests

Conversation

@mattlevine22
Copy link
Copy Markdown
Collaborator

@mattlevine22 mattlevine22 commented May 22, 2026

Demonstrating xfailing tests that I would like to work:

Priority level 1:

  • seems like Discretizer + Hierarchical is not
    tests/test_plate_vector_initial_mean_continuous_filters.py

Priority level 2:

  • make reshaping needs consistent and issue helpful errors. For example, why do we need to broadcast initial_mean across M trajectories, but don't need to do this for the initial_covariance? The reason is a bit subtle.
    'tests/test_desirable_shared_initial_mean_hierarchical.py'
    and
    `tests/test_plate_vector_initial_mean_continuous_drift_diffusion.py'

@mattlevine22 mattlevine22 marked this pull request as ready for review May 26, 2026 14:27
@mattlevine22 mattlevine22 requested a review from DanWaxman May 26, 2026 14:28
Copy link
Copy Markdown
Collaborator

@DanWaxman DanWaxman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that almost all of these should work; thanks!

@DanWaxman DanWaxman merged commit e0a164c into main May 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants