Skip to content

Reformat cached_network_image_web for the current Dart formatter - #1047

Merged
mvanbeusekom merged 3 commits into
mainfrom
rick/fpl-33-web-format
Sep 23, 2026
Merged

mvanbeusekom merged 3 commits into
mainfrom
rick/fpl-33-web-format

Conversation

@rickdijk

Copy link
Copy Markdown
Collaborator

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix (CI). Pure reformat of cached_network_image_web, plus a patch bump.

⤵️ What is the current behavior?

The workflows install whatever Flutter stable is current, and the formatter's style changed, so the Format job fails on main: https://github.com/Baseflow/flutter_cached_network_image/actions/runs/35819343307 (platform_web) and https://github.com/Baseflow/flutter_cached_network_image/actions/runs/33173987545 (web)

🆕 What is the new behavior (if this is a feature change)?

dart format . output from Dart 3.13.2 (Flutter 3.47.2 stable), with no hand edits, in its own PR as AGENTS.md asks. Version 2.0.0 → 2.0.1, with a CHANGELOG entry.

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

Ran locally: dart format --set-exit-if-changed ., flutter analyze (no issues), flutter test --platform chrome (1 passed). On CI, check that Format now passes in both web and platform_web.

📝 Links to relevant issues/docs

Companion to PR 1045, which fixes the cached_network_image workflow. web.yaml has no workflow_dispatch trigger, so this PR is also what gets it a fresh run.

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current main

🤖 Generated with Claude Code

rickdijk and others added 2 commits September 22, 2026 21:43
Pure `dart format .` output from Dart 3.13.2 (Flutter 3.47.2 stable), with no hand edits. The CI Format job runs `dart format --set-exit-if-changed .` on this package and fails on main since the formatter moved to the tall style.

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
@mvanbeusekom
mvanbeusekom merged commit a96d31c into main Sep 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants