Skip to content

SWI-12730 Fix Silent Null Swallowing #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckoegel merged 2 commits into from
Sep 18, 2026
+7 −3
Merged

SWI-12730 Fix Silent Null Swallowing #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67756fd
SWI-12730 Fix Silent Null Swallowing
ckoegel Sep 17, 2026
3e94313
pin guid
ckoegel Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions custom_templates/Configuration.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,11 @@ namespace {{packageName}}.Client
string.Format("Error calling {0}: {1}", methodName, response.RawContent),
response.RawContent, response.Headers);
}
{{^netStandard}}
if (status == 0)
if (status == 0 || !string.IsNullOrEmpty(response.ErrorText))
{
return new ApiException(status,
string.Format("Error calling {0}: {1}", methodName, response.ErrorText), response.ErrorText);
}
{{/netStandard}}
return null;
};

Expand Down
1 change: 1 addition & 0 deletions openapi-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ packageName: Bandwidth.Standard
packageTags: Bandwidth
targetFramework: netstandard2.0
templateDir: custom_templates
packageGuid: "{0B827FE6-C4E9-4144-A195-8A00B3C063F4}"
5 changes: 5 additions & 0 deletions src/Bandwidth.Standard/Client/Configuration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ public class Configuration : IReadableConfiguration
string.Format("Error calling {0}: {1}", methodName, response.RawContent),
response.RawContent, response.Headers);
}
if (status == 0 || !string.IsNullOrEmpty(response.ErrorText))
{
return new ApiException(status,
string.Format("Error calling {0}: {1}", methodName, response.ErrorText), response.ErrorText);
}
return null;
};

Expand Down
Loading