feat!: update for BanManager v8 compatibility#36
Closed
Conversation
- Bump all BanManager dependencies from 7.11.0-SNAPSHOT to 8.0.0-SNAPSHOT - Bump Java target from 1.8 to 17 across CommonConfig, LibsConfig, sponge-api7 - Migrate PinCommand from message.toString() to message.sendTo(sender) - Update CommonPlayerDeniedListener to use getRawTemplate() and <pin> tag - Update tests for MiniMessage template format - Add null template test case for handlePin
Member
Author
|
Superseded by the following merged work:
Re-merging this branch as-is would regress all three (re-add the Sponge7 module, re-inline the migrations, replace the minimal MiniMessage e2e overrides with the full 472-line BanManager copies). The two genuinely useful cleanups still unique to this branch — |
confuser
added a commit
that referenced
this pull request
Apr 18, 2026
Two small cleanups salvaged from the closed #36 that #40 didn't pick up: - buildSrc/LibsConfig.kt: bump the libs module's source/target compatibility and TARGET_JVM_VERSION attribute from 1.8 to 17, matching the v8 Java 17 baseline already applied to the rest of the project in #40. - PinCommand.java: replace the two remaining sender.sendMessage(Message.get(...).toString()) calls with Message.get(...).sendTo(sender) so error messages render through the MiniMessage pipeline like the other pin messages instead of as the raw Component.toString() output.
3 tasks
confuser
added a commit
that referenced
this pull request
Apr 18, 2026
…nd (#41) Two small cleanups salvaged from the closed #36 that #40 didn't pick up: - buildSrc/LibsConfig.kt: bump the libs module's source/target compatibility and TARGET_JVM_VERSION attribute from 1.8 to 17, matching the v8 Java 17 baseline already applied to the rest of the project in #40. - PinCommand.java: replace the two remaining sender.sendMessage(Message.get(...).toString()) calls with Message.get(...).sendTo(sender) so error messages render through the MiniMessage pipeline like the other pin messages instead of as the raw Component.toString() output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates BanManager-WebEnhancer to compile and run against BanManager v8.
7.11.0-SNAPSHOTto8.0.0-SNAPSHOTCommonConfig.kt,LibsConfig.kt, andsponge-api7/build.gradle.ktsPinCommandfrommessage.toString()tomessage.sendTo(sender)CommonPlayerDeniedListenerto usegetRawTemplate()and<pin>MiniMessage tag instead of[pin]bracket syntax&-codes to MiniMessage formathandlePinDepends on: BanManagement/BanManager#1063
Scope
Test plan
./gradlew buildpasses across all modules (99 tasks)./gradlew :BanManagerWebEnhancerCommon:test— all unit tests pass