feat(release): tell tenjin when the MCP Registry pin goes stale - #181
Open
A1igator wants to merge 1 commit into
Open
feat(release): tell tenjin when the MCP Registry pin goes stale#181A1igator wants to merge 1 commit into
A1igator wants to merge 1 commit into
Conversation
A successful `changeset publish` now files one issue on BackTrackCo/tenjin naming the newly published tenjin-cli version and the files that must move with the pin. The registry rejects version ranges, so the pin is exact and lives in the other repo, where nothing notices it going stale until the next registry publish preflight weeks later. Closes #98 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
A successful
changeset publishnow files one issue onBackTrackCo/tenjinasking for the MCP Registry pin bump, so a release stops staling that listing in silence. Option 1 (notify) from #98; the auto-PR shape and auto-publishing stay out.scripts/notify-registry-pin.shreads the published version fromchangesets/action'spublishedPackages, dedupes on an exact open-issue title match, and files an issue namingserver.json,package.json, andlib/mcp/metadata.ts(whereMCP_SERVER_INFOlives since tenjin#493), plus the rule that the registry publish stays manual and follows a promoted deploy..github/workflows/release.ymlgates the new step onsteps.publish.outputs.published == 'true', so a dispatch that shipped nothing announces nothing.scripts/pack-smoke.shasserts the packedmcpNameisblog.tenjin/tenjin, the npm precondition Wire the MCP Registry packages pin into the release pipeline #98 asks for: dropping it breaks tenjin's next registry publish, not anything here.Risk: the step runs after npm already has the package, so a failure there cannot un-publish. Until the owner action below is done it will fail the release run (loudly, on purpose: an unnoticed miss is the bug being fixed).
Owner action required
Create repo secret
RELEASE_CROSSREPO_TOKEN: a fine-grained PAT scoped toBackTrackCo/tenjinwith Issues: read and write.#98 assumed the release-bot token already in that job would do. It will not: the
x402r-release-botinstallation holdscontents: write,pull_requests: write,metadata: readand no Issues permission, and it is installed on this repo (andx402r-sdk), not ontenjin. Widening the App would need both a new permission grant and a new repo in its installation, so the token is parameterized on a named secret instead.RELEASING.mdcarries this as one-time owner setup step 4.Testing
src/notify-registry-pin.test.ts: 7 cases driving the real script withghstubbed. Files once per version; files nothing on a no-op publish or when the publish carried notenjin-cli; skips a same-title open issue; still files when only the previous version's issue is open (the loose--searchalone would swallow it); fails and writes nothing without a token; links the release run.pnpm lint,pnpm typecheck,pnpm format:check: clean.pnpm test: 2147 passed, 10 skipped.bash scripts/pack-smoke.sh: PASS, including the newmcpNameassertion.gh's gojq resolvesenv.TITLE, which the dedupe query depends on.Closes #98