Skip to content

Fix deprecations: declare the already-locked @opencode-ai/sdk (no version bumps) - #102

Merged
BacLuc merged 1 commit into
BacLuc:mainfrom
bacluc-agent:fix/deprecation-sdk-api-usage
Oct 18, 2026
Merged

BacLuc merged 1 commit into
BacLuc:mainfrom
bacluc-agent:fix/deprecation-sdk-api-usage

Conversation

@bacluc-agent

@bacluc-agent bacluc-agent commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Related to bacluc-agent/agent-todo#369

@BacLuc — no version string is touched anywhere: renovate stays the only source of version updates, as required by your review on #100 ("Do not do this by hand, we have renovate": #100 (review)).

Management summary

src/completion-check-command.ts:2 imports Event from @opencode-ai/sdk, but that package was never declared in package.json — it resolved only through @opencode-ai/plugin@1.18.34's exact pin, so any unrelated resolution change would break the typecheck. This PR declares "@opencode-ai/sdk": "1.18.34", the exact version already locked in package-lock.json, removing the latent drift with 2 added lines, 0 deletions and zero version bumps.

Verification evidence

All runs below were started manually with workflow_dispatch and are the builder's/testing team's own testing; the automatic push/PR-triggered CI runs are deliberately not cited.

Tester's own run — https://github.com/bacluc-agent/opencode-completion-check-command/actions/runs/38759226695 (event workflow_dispatch, conclusion success, headSha 8ff9ac29b7e256d57b0554625393cc2d73dfc135), job 116505757243:

Builder's own manual run — event workflow_dispatch, verified via API:

Run Model What happened Result Failure reason
https://github.com/bacluc-agent/opencode-completion-check-command/actions/runs/38758387021 opencode/big-pickle Manual gh workflow run ci.yaml on fix/deprecation-sdk-api-usage: npm ci, typecheck, 116 tests, format:check success none
https://github.com/bacluc-agent/opencode-completion-check-command/actions/runs/38759226695 opencode/big-pickle Tester's own manual CI dispatch on the branch (npm ci, typecheck, 116 tests, format:check) success none
Extra context

Rejected approach, not repeated — #100 was closed after BacLuc's review "Do not do this by hand, we have renovate" (#100 (review)). This change therefore declares a dependency that is already resolved at the already-locked version; no dependency or action version is edited by hand.

Deprecation audit (bacluc-agent/agent-todo#369)

  • .github/workflows/ci.yaml, auto-release.yaml, release.yaml: no ::set-output, ::save-state or ::set-env; all jobs use ubuntu-latest (no retired runner image); actions/setup-node uses node-version: 24; on: events are push, pull_request, workflow_dispatch and tag pushes — no removed event types; no deprecated action inputs; every action is commit-SHA-pinned with a version comment (actions/checkout # v7, actions/setup-node # v7.0.0, mikepenz/release-changelog-builder-action # v6.4.0, ncipollo/release-action # v1.21.0).
  • Plugin/SDK API usage is current: @opencode-ai/plugin 1.18.34 and @opencode/plugin 2.0.29 are exactly what renovate last set (Update dependency @opencode-ai/plugin to v1.18.34 #101); this PR only adds @opencode-ai/sdk at that same already-locked 1.18.34.
  • One unpinned-runtime warning recorded and deliberately not bumped: projectsyn/pr-label-tag-action@796e1eaeafa4de313848e03bd5341d55a08a596d # v1.3.1 (third-party, SHA-pinned) declares runs.using: node20, which GitHub force-runs on the node24 runtime; v1.3.1 is its newest release (2026-01-29), and version changes are renovate's lane, not a hand edit.
  • Fork PR chore: update deprecated actions and dependencies bacluc-agent/opencode-completion-check-command#3 (hand-bumped versions, targeting the wrong repo) is closed; nothing was built on it.

Local verification per the target repo AGENTS.md (/completion-check-command): npm ci --no-audit --no-fund, npm run typecheck, npm test → 2 test files, 116 tests passed, npm run format:check → "All matched files use Prettier code style!" — all green. git diff --stat: package-lock.json | 1 +, package.json | 1 +, 2 files changed, 2 insertions(+), 0 deletions(-).

Head note — bacluc-agent has no push permission on BacLuc/opencode-completion-check-command (push: false, verified via the API), so the branch fix/deprecation-sdk-api-usage was pushed to the fork bacluc-agent/opencode-completion-check-command and this PR's head is bacluc-agent:fix/deprecation-sdk-api-usage with base BacLuc:main — the same shape as PRs #99, #92 and #82.

@BacLuc
BacLuc merged commit c005903 into BacLuc:main Oct 18, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants