Repository navigation
Fix deprecations: declare the already-locked @opencode-ai/sdk (no version bumps) - #102
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to bacluc-agent/agent-todo#369
@BacLuc — no version string is touched anywhere: renovate stays the only source of version updates, as required by your review on #100 ("Do not do this by hand, we have renovate": #100 (review)).
Management summary
src/completion-check-command.ts:2importsEventfrom@opencode-ai/sdk, but that package was never declared inpackage.json— it resolved only through@opencode-ai/plugin@1.18.34's exact pin, so any unrelated resolution change would break the typecheck. This PR declares"@opencode-ai/sdk": "1.18.34", the exact version already locked inpackage-lock.json, removing the latent drift with 2 added lines, 0 deletions and zero version bumps.Verification evidence
All runs below were started manually with
workflow_dispatchand are the builder's/testing team's own testing; the automatic push/PR-triggered CI runs are deliberately not cited.Tester's own run — https://github.com/bacluc-agent/opencode-completion-check-command/actions/runs/38759226695 (event
workflow_dispatch, conclusionsuccess, headSha8ff9ac29b7e256d57b0554625393cc2d73dfc135), job 116505757243:Builder's own manual run — event
workflow_dispatch, verified via API:gh workflow run ci.yamlonfix/deprecation-sdk-api-usage: npm ci, typecheck, 116 tests, format:checkExtra context
Rejected approach, not repeated — #100 was closed after BacLuc's review "Do not do this by hand, we have renovate" (#100 (review)). This change therefore declares a dependency that is already resolved at the already-locked version; no dependency or action version is edited by hand.
Deprecation audit (bacluc-agent/agent-todo#369)
.github/workflows/ci.yaml,auto-release.yaml,release.yaml: no::set-output,::save-stateor::set-env; all jobs useubuntu-latest(no retired runner image);actions/setup-nodeusesnode-version: 24;on:events arepush,pull_request,workflow_dispatchand tag pushes — no removed event types; no deprecated action inputs; every action is commit-SHA-pinned with a version comment (actions/checkout# v7,actions/setup-node# v7.0.0,mikepenz/release-changelog-builder-action# v6.4.0,ncipollo/release-action# v1.21.0).@opencode-ai/plugin1.18.34 and@opencode/plugin2.0.29 are exactly what renovate last set (Update dependency @opencode-ai/plugin to v1.18.34 #101); this PR only adds@opencode-ai/sdkat that same already-locked 1.18.34.projectsyn/pr-label-tag-action@796e1eaeafa4de313848e03bd5341d55a08a596d # v1.3.1(third-party, SHA-pinned) declaresruns.using: node20, which GitHub force-runs on the node24 runtime; v1.3.1 is its newest release (2026-01-29), and version changes are renovate's lane, not a hand edit.Local verification per the target repo AGENTS.md (
/completion-check-command):npm ci --no-audit --no-fund,npm run typecheck,npm test→ 2 test files, 116 tests passed,npm run format:check→ "All matched files use Prettier code style!" — all green.git diff --stat:package-lock.json | 1 +,package.json | 1 +, 2 files changed, 2 insertions(+), 0 deletions(-).Head note —
bacluc-agenthas no push permission onBacLuc/opencode-completion-check-command(push: false, verified via the API), so the branchfix/deprecation-sdk-api-usagewas pushed to the forkbacluc-agent/opencode-completion-check-commandand this PR's head isbacluc-agent:fix/deprecation-sdk-api-usagewith baseBacLuc:main— the same shape as PRs #99, #92 and #82.