Repository navigation
feat: make matrix tests the default (issue 74) - #1
Open
bacluc-agent wants to merge 2 commits into
Open
bacluc-agent wants to merge 2 commits into
bacluc-agent wants to merge 2 commits into
Conversation
added 2 commits
October 20, 2026 12:44
Matrix (multi-instance) tests are now generated unconditionally. bacluc-agent/agent-vshn-todo#74
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
add_matrixcookiecutter option from the commodore-component-template and always generates matrix-based test workflows and Makefile targets. Components now always get the matrixtest.yamlworkflow; the recursive Makefile targets are named after thetests/<case>.ymlpaths and remain conditional onadd_golden == "y".Rendering is byte-identical to what the template previously produced with
add_matrix=y— components previously generated withadd_matrix=ngain the matrix test workflow and the Makefile targets for it, so per the release note they must runmake gen-golden-allonce after the cruft update.This is a mirror of bacluc-agent#4 and implements bacluc-agent/agent-vshn-todo#74.
Changes
cookiecutter.json: drop theadd_matrixoptionhooks/post_gen_project.py: remove theadd_matrixvariable and its conditional — when golden tests are enabled, the renovatepostUpgradeTaskscommand is now alwaysmake gen-golden-all(previouslymake gen-goldenwhenadd_matrix=n).github/workflows/test.yaml(template): drop the non-matrix variant{{ cookiecutter.slug }}/.github/workflows/test.yamlandMakefile/Makefile.vars.mk: always render the matrix strategy in the test workflow (and in the golden job); the recursive Makefile targets named after thetests/<case>.ymlpaths (plusgolden-diff-all) are no longer gated onadd_matrixand remain conditional onadd_golden == "y"Evidence
2d891ef)git grep add_matrix HEAD→ 0 hitsgit diff --stat de8e8df..HEAD→ 6 files changed, 4 insertions(+), 28 deletions(-)projectsyn/component-icap-virusscan: cruft update succeeds against this branch (recorded commit2d891ef,add_matrixdropped from context), rendered-file diff contains only pre-existing drift (checkout v5→v6, release-changelog-builder v5→v6, jsonnetfmt--in-placemove) and zero issue-74-related changes; all 3make testinstances andgolden-diff-allexit 0Release note
Components previously generated with
add_matrix=nmust runmake gen-golden-allonce after the cruft update to adopt the matrix test workflows and targets.Closes bacluc-agent/agent-vshn-todo#74