Add quantize and cull unused blocks - #23
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QuantizeBlockandCullUnusedBlockas thin wrappers around glTF-Transform's defaultquantize()andprune()behavior.QuantizeBlockand export both blocks.Validation
Both new integration tests, the full existing test suite (179 tests), changed-file ESLint, typecheck, and the core build passed. The build emitted the existing TypeScript/API Extractor version warning.
Code review
Findings
No findings. No follow-up code changes were needed.
Reviewed immutable range
eae03b45471c18361b1e8850ebaf0aa855490fa9..358803fd5291658f7221886647c4864418a154bbusing the code-review skill. All reviewers used GPT-5.6 Sol with High reasoning effort as requested.Coverage
Summary: 0 findings — 0 critical, 0 high, 0 medium, 0 low. Coverage: 8/8 selected reviewers completed.